Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Letter Spacing option #302

Merged
merged 3 commits into from
Jul 2, 2024
Merged

feat: Added Letter Spacing option #302

merged 3 commits into from
Jul 2, 2024

Conversation

mpa12
Copy link
Contributor

@mpa12 mpa12 commented Jul 1, 2024

Summary

Added Letter Spacing option

resolves #251

Type of change

  • New feature (added a non-breaking change which adds functionality)

How Has This Been Tested?

  • Ran tests with composer test
  • Added or updated test cases to test new features

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

The formatting can be fixed with composer format, but you don't need to worry about it since it can be done when merging.

Just one suggestion below

@DenverCoder1 DenverCoder1 changed the title #251 Added Letter Spacing option feat: Added Letter Spacing option Jul 1, 2024
@mpa12
Copy link
Contributor Author

mpa12 commented Jul 2, 2024

@DenverCoder1 Added tooltip and removed the word "Font"

@mpa12
Copy link
Contributor Author

mpa12 commented Jul 2, 2024

Some error in "Format with Prettier"

Run EndBug/add-and-commit@v9
  with:
    message: style: Formatted code with Prettier
    default_author: github_actions
    add: .
    cwd: .
    fetch: --tags --force
    pathspec_error_handling: ignore
    push: true
    github_token: ***
Running in /home/runner/work/readme-typing-svg/readme-typing-svg
Add input parsed as single string, running 1 git add command.
> Using 'github-actions <41898[2](https://github.com/DenverCoder1/readme-typing-svg/actions/runs/9760791461/job/26940859740?pr=302#step:7:2)82+github-actions[bot]@users.noreply.github.com>' as author.
> Using "style: Formatted code with Prettier" as commit message.
Internal logs
  > Staging files...
  > Adding files...
  > No files to remove.
  > Checking for uncommitted changes in the git working tree...
  > Found 5 changed files.
  > Fetching repo...
  {
    raw: '',
    remote: null,
    branches: [],
    tags: [],
    updated: [],
    deleted: []
  }
  > Not pulling from repo.
  > Creating commit...
  {
    author: null,
    branch: 'main',
    commit: '28e0c4[3](https://github.com/DenverCoder1/readme-typing-svg/actions/runs/9760791461/job/26940859740?pr=302#step:7:3)f41a473cd8e214d42c2eda2a4d76b9652',
    root: false,
    summary: { changes: 5, insertions: 10, deletions: 28 }
  }
  > No tag info provided.
  > Pushing commit to repo...
  Error: Error: Pushing to https://github.com/mpa12/readme-typing-svg
  remote: Permission to mpa12/readme-typing-svg.git denied to github-actions[bot].
  fatal: unable to access 'https://github.com/mpa12/readme-typing-svg/': The requested URL returned error: [4](https://github.com/DenverCoder1/readme-typing-svg/actions/runs/9760791461/job/26940859740?pr=302#step:7:4)03
  
Outputs
  committed: true
  commit_long_sha: 28e0c43f41a473cd8e214d42c2eda2a4d76b96[5](https://github.com/DenverCoder1/readme-typing-svg/actions/runs/9760791461/job/26940859740?pr=302#step:7:5)2
  commit_sha: 28e0c43
  pushed: false
  tagged: false
  tag_pushed: false
Error: Error: Pushing to https://github.com/mpa12/readme-typing-svg
remote: Permission to mpa[12](https://github.com/DenverCoder1/readme-typing-svg/actions/runs/9760791461/job/26940859740?pr=302#step:7:13)/readme-typing-svg.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/mpa12/readme-typing-svg/': The requested URL returned error: 403

@mpa12
Copy link
Contributor Author

mpa12 commented Jul 2, 2024

I added the token in the settings and jobs passed without errors

@DenverCoder1
Copy link
Owner

Thanks!

@DenverCoder1 DenverCoder1 merged commit d57e8c2 into DenverCoder1:main Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Letter Spacing
2 participants