Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX avoid from re-initializing array result on nested hook getEntity #30626

Merged
merged 1 commit into from
Sep 9, 2024
Merged

FIX avoid from re-initializing array result on nested hook getEntity #30626

merged 1 commit into from
Sep 9, 2024

Conversation

kkhelifa-opendsi
Copy link
Contributor

@kkhelifa-opendsi kkhelifa-opendsi commented Aug 13, 2024 •
edited
Loading

FIX avoid from re-initializing result on nested hook getEntity for also resArray

See already merged #27799 who manage resPrint only

@kkhelifa-opendsi kkhelifa-opendsi mentioned this pull request Aug 13, 2024
Merged
@lvessiller-opendsi
Copy link
Contributor

@rycks
it's ok for me.

@eldy eldy added Pending analysis of PR PR needs discussion with other dev. PR set to pending status. May be debated during a devcamp. Pending analysis of PR (maintenance team) PR is in a maintenance branch with several approvers. Waiting approval of all of them. and removed Pending analysis of PR PR needs discussion with other dev. PR set to pending status. May be debated during a devcamp. labels Aug 14, 2024
rycks
rycks approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@rycks rycks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me, i have to manage that strange thing into my module

@eldy eldy merged commit d29ebee into Dolibarr:18.0 Sep 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycks rycks rycks approved these changes

@lvessiller-opendsi lvessiller-opendsi lvessiller-opendsi approved these changes

Assignees
No one assigned
Labels
Pending analysis of PR (maintenance team) PR is in a maintenance branch with several approvers. Waiting approval of all of them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkhelifa-opendsi @lvessiller-opendsi @rycks @eldy