This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Refactor code for the browser session storage #18153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschanaj
changed the title
cschanaj
changed the title
|
@cschanaj Is the goal here to generalize |
|
@pipboy96 Yes, it also avoid using multiple |
pipboy96
reviewed
Jul 1, 2019
|
Can you also turn this into a ES6 class? |
pipboy96
approved these changes
Jul 2, 2019
pipboy96
approved these changes
Jul 3, 2019
|
Thanks! |
|
This is a great refactor. |
This was referenced Sep 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.