Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Ignore loopback and private network addresses (such as 192.168.0.1) #18565

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Ignore loopback and private network addresses (such as 192.168.0.1) #18565

merged 1 commit into from
Oct 24, 2019

Conversation

pipboy96
Copy link
Contributor

@pipboy96 pipboy96 commented Oct 15, 2019

Closes #18474.

@pipboy96 pipboy96 requested review from zoracon and cschanaj October 15, 2019 19:56
@pipboy96 pipboy96 marked this pull request as ready for review October 15, 2019 20:22
Copy link
Collaborator

@cschanaj cschanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, I think the current practice require a semicolon for each statement?

@pipboy96
Copy link
Contributor Author

@cschanaj I think there is no rule about use of ;, but @zoracon would be a better person to ask.

@pipboy96
Copy link
Contributor Author

@cschanaj Thanks! It now has 100% coverage.

@pipboy96 pipboy96 requested a review from cschanaj October 16, 2019 17:37
@zoracon zoracon added this to the Before the Next Release milestone Oct 16, 2019
@zoracon
Copy link
Contributor

zoracon commented Oct 21, 2019

@cschanaj I think there is no rule about use of ;, but @zoracon would be a better person to ask.

@pipboy96 let's stick to using semicolons since I want as much consistency and readability as we can in the repo. There was no hard rule in place but it is general practice. The file is generally clean but want to avoid future potential debugging issues like concatenated statements.

@pipboy96
Copy link
Contributor Author

@zoracon any idea what causes this error?

@zoracon
Copy link
Contributor

zoracon commented Oct 24, 2019

@pipboy96 Merged in that web-crypto temporary fix. Will investigate more

@pipboy96 pipboy96 requested review from zoracon and removed request for zoracon October 24, 2019 09:44
@pipboy96
Copy link
Contributor Author

@zoracon I think this is ready for review.

Copy link
Contributor

@zoracon zoracon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zoracon zoracon merged commit 8671320 into EFForg:master Oct 24, 2019
@pipboy96 pipboy96 deleted the local-ips branch October 24, 2019 21:43
@taokann
Copy link

taokann commented Jan 8, 2020

Hello, I searched the web for this issue and found here that's already resolved.
Unfortunately I have the right version (2019.11.7) but I still have to manually whitelist all local IPs.
I read the PR's code, I don't know the project well but it seems that the feature is only added in the Chromium version. Is it right ? Will it be available for Firefox too ? I'm using Firefox 68.3.0 ESR with Debian Buster.

@pipboy96
Copy link
Contributor Author

pipboy96 commented Jan 8, 2020

@taokann Please wait until the next HTTPS Everywhere extension release, which would include #18755 patch that fixes a typo in this PR. Also, Firefox is also using Chromium version since WebExtensions API transition (which completed in 2017).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude all local subnets from HTTPSE
4 participants