-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Ignore loopback and private network addresses (such as 192.168.0.1) #18565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides, I think the current practice require a semicolon for each statement?
@cschanaj Thanks! It now has 100% coverage. |
@pipboy96 let's stick to using semicolons since I want as much consistency and readability as we can in the repo. There was no hard rule in place but it is general practice. The file is generally clean but want to avoid future potential debugging issues like concatenated statements. |
@zoracon any idea what causes this error? |
@pipboy96 Merged in that web-crypto temporary fix. Will investigate more |
Co-Authored-By: Chan Chak Shing <[email protected]>
@zoracon I think this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hello, I searched the web for this issue and found here that's already resolved. |
Closes #18474.