Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Fix minor UX issues on the options page #19182

Merged
merged 1 commit into from
May 18, 2020
Merged

Fix minor UX issues on the options page #19182

merged 1 commit into from
May 18, 2020

Conversation

pipboy96
Copy link
Contributor

@pipboy96 pipboy96 commented Apr 20, 2020 •
edited
Loading

No description provided.

@pipboy96 pipboy96 requested a review from zoracon April 20, 2020 10:54
@pipboy96 pipboy96 closed this Apr 20, 2020
@pipboy96 pipboy96 reopened this Apr 20, 2020
@pipboy96
Copy link
Contributor Author

@zoracon Would it be a good idea to also make <textarea>s resize automatically?

@pipboy96 pipboy96 removed the request for review from zoracon April 27, 2020 14:12
@pipboy96 pipboy96 marked this pull request as ready for review April 27, 2020 14:13
@pipboy96 pipboy96 requested a review from zoracon April 27, 2020 14:13
@pipboy96 pipboy96 requested review from zoracon and removed request for zoracon May 16, 2020 23:54
@pipboy96 pipboy96 changed the title [WIP] Fix minor UX issues on the options page Fix minor UX issues on the options page May 16, 2020
@pipboy96 pipboy96 mentioned this pull request May 16, 2020
Closed
@zoracon
Copy link
Contributor

zoracon commented May 18, 2020

@zoracon Would it be a good idea to also make <textarea>s resize automatically?

I have to further discuss this point with a designer, do not think it's necessary at the moment.

zoracon
zoracon approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@zoracon zoracon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revisit the static shaping of this but at the moment it's not a high priority

@zoracon zoracon merged commit 02c32d1 into EFForg:master May 18, 2020
@pipboy96 pipboy96 deleted the fix-minor-ux-issue branch May 18, 2020 23:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zoracon zoracon zoracon approved these changes

Assignees
No one assigned
Labels
enhancement ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pipboy96 @zoracon