Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Fix unexpected arithmetic operations on strings #20043

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Fix unexpected arithmetic operations on strings #20043

merged 3 commits into from
Jun 9, 2021

Conversation

cschanaj
Copy link
Collaborator

@cschanaj cschanaj commented Apr 12, 2021 •
edited
Loading

@pipboy96 would you kindly check if this is a bug?

octet is a string type, per typescript check

the right-hard side of an arithmetic operation must be of type any, number, bigint or an enum type.

octetN is not used otherwise.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring existing code
  • New Ruleset
  • Existing Ruleset

@cschanaj cschanaj requested a review from pipboy96 April 12, 2021 03:37
@cschanaj cschanaj added the bug label Apr 12, 2021
@cschanaj cschanaj requested a review from zoracon April 12, 2021 03:38
@cschanaj cschanaj changed the title Update ip_utils.js Fix unexpected arithmetic operations on strings Apr 12, 2021
@cschanaj cschanaj closed this Apr 12, 2021
@cschanaj cschanaj reopened this Apr 12, 2021
@cschanaj cschanaj mentioned this pull request Apr 14, 2021
Closed
@cschanaj
Copy link
Collaborator Author

cschanaj commented Jun 4, 2021

@zoracon is there anything blocking this PR?

@zoracon zoracon merged commit d0b4b0f into EFForg:master Jun 9, 2021
@cschanaj cschanaj deleted the fix-ip-parse-util-typo branch June 10, 2021 03:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zoracon zoracon zoracon approved these changes

@pipboy96 pipboy96 Awaiting requested review from pipboy96

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cschanaj @zoracon