Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5878 Password protected messages compliance #5879

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Dec 6, 2024

This PR implemented password protected messages compliance

close #5878 // if this PR closes an issue


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review December 6, 2024 05:17
@ioanmo226 ioanmo226 requested a review from sosnovsky as a code owner December 6, 2024 05:17
@ioanmo226 ioanmo226 requested a review from sosnovsky December 9, 2024 00:51
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well 👍

@ioanmo226 ioanmo226 requested a review from sosnovsky December 9, 2024 10:51
@ioanmo226 ioanmo226 requested a review from sosnovsky December 11, 2024 00:50
@ioanmo226 ioanmo226 requested a review from sosnovsky December 11, 2024 10:40
@ioanmo226
Copy link
Collaborator Author

@sosnovsky Please check current implementation

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now and well-tested, thanks!

@sosnovsky sosnovsky merged commit 2f257e9 into master Dec 11, 2024
13 checks passed
@sosnovsky sosnovsky deleted the 5878-password-protected-messages-compliance branch December 11, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password-protected messages compliance
2 participants