Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when comparing empty string in mail rules #2254

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Fix bug when comparing empty string in mail rules #2254

merged 1 commit into from
Jan 19, 2021

Conversation

Phylu
Copy link
Contributor

@Phylu Phylu commented Jan 13, 2021 •
edited
Loading

This PR fixes #1064.

@CodeMouse92 CodeMouse92 requested a review from bengotow January 13, 2021 14:47
@bengotow
Copy link
Collaborator

This looks good to me 👍 I think that this should make the Subject "equals" <empty input>? mail rule work as long as the provider isn't changing the subject to "No Subject" on their own? Thanks for taking a look @Phylu!

@bengotow bengotow merged commit a74c6c6 into Foundry376:master Jan 19, 2021
@Phylu Phylu deleted the bugfix/1064-rule-empty-subject branch January 19, 2021 08:05
exprez135 pushed a commit to exprez135/Mailspring-Libre that referenced this pull request Feb 20, 2021
@Phylu @exprez135
Fix bug when comparing empty string in mail rules (Foundry376#2254)
9a81459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengotow bengotow Awaiting requested review from bengotow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]Provide rules for empty subject or body
2 participants
@Phylu @bengotow