Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for upcoming livestream trailers #6375

Draft
wants to merge 2 commits into
base: development
Choose a base branch
from
Draft

Add support for upcoming livestream trailers #6375

wants to merge 2 commits into from
+51 −37

Conversation

ChunkyProgrammer
Copy link
Member

Add support for upcoming livestream trailers

Pull Request Type

  • Feature Implementation

Related issue

LuanRT/YouTube.js#842

Description

This will be difficult to test but some upcoming videos have trailers to view before the stream is uploaded. For example, this is an upcoming video that has a trailer: https://youtu.be/t28qkILDe58 (it will most likely be uploaded by the time this PR gets reviewed).

Screenshots

Upcoming video with trailer:
image

Upcoming video without trailer:
image

Other video (movie) with trailer:
image

Testing

  • kinda difficult, find an upcoming live stream that has a trailer associated with it and go to the watch page
  • find an upcoming live stream that doesn't have a trailer associated with it and go to the watch page
  • find a movie that has a trailer associated with it and go to the watch page

Desktop

  • OS: Fedore Linux
  • OS Version: 41 KDE
  • FreeTube version: 0.22.x (latest nightly)

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-upcoming-livestream-trailers branch from df57f37 to d35f4a4 Compare January 9, 2025 16:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-upcoming-livestream-trailers branch from d35f4a4 to 6d8e7f8 Compare January 20, 2025 14:46
This was referenced Jan 21, 2025
Draft
Merged
@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-upcoming-livestream-trailers branch from a547596 to be1663d Compare January 21, 2025 13:21
@ChunkyProgrammer
Copy link
Member Author

Having trouble finding other upcoming videos with trailers so I'll leave this as a draft for now (also it looks like the trailer was removed from the test video?)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-upcoming-livestream-trailers branch from be1663d to 0db38f7 Compare February 10, 2025 18:34
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Wait a sec...upstream merged and released a while ago. Any reason for this to be in draft?

@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Feb 10, 2025 •
edited
Loading

Wait a sec...upstream merged and released a while ago. Any reason for this to be in draft?

I haven't found another video to test with so I left it in draft

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ChunkyProgrammer ChunkyProgrammer force-pushed the add-support-for-upcoming-livestream-trailers branch from 0db38f7 to 587dadc Compare February 20, 2025 15:00
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absidue absidue absidue left review comments

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc @absidue