Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6330: Commented out overflow-x: hidden to resolve scrollbar issue #6655

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

sullivanlng
Copy link
Contributor

Title

Fix unnecessary vertical scrollbar in settings page

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #6330

Description

This pull request fixes an issue where an unnecessary vertical scrollbar appeared in the settings page for certain languages (e.g., German, Turkish).

Changes made:

  • Commented out the overflow-x: hidden property in .settingsSections and .switchRow within the Settings.css file.

Screenshots

Before :
20250121_CAP_Bug

After :
20250121_CAP_BugFix

Testing

Approach:

  • Tested across multiple languages that previously showed the issue (German, Polish, Turkish).
  • Used the toggle device bar to simulate different screen sizes and validate responsive behavior.

Behavior Confirmed:

  • The scrollbar no longer appears unnecessarily.
  • No new horizontal scrollbars were introduced as a side effect.

Desktop

  • OS: Windows 11
  • OS Version: 23H2
  • FreeTube version: 0.22.1

Additional context

  • Left the commented code in place to make reactivation easier, if needed in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for addressing this!

Comment on lines +8 to 9
/* overflow-x: hidden; */
max-inline-size: 90%;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: if we don't need it, we don't need it

Suggested change
/* overflow-x: hidden; */
max-inline-size: 90%;
max-inline-size: 90%;

Copy link
Collaborator

@kommunarr kommunarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (blocking): Seeing a horizontal scrollbar now on certain compressed screen sizes.

Screenshot_20250127_164225

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jan 27, 2025
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: In some languages, an extra scrollbar appears in the settings
3 participants