Fix: search history text overflows if search term is long #6728
Conversation
github-actions
bot
added
the
PR: waiting for review
|
When making UI changes it is always a good idea to provide before and after screenshots. Please re-add the parts of the template that you removed and add screenshots to it. |
absidue
added
U: Waiting for Response from Author
PR: changes requested
and removed
PR: waiting for review
There was a problem hiding this comment.
When we wanted to introduce this feature i pointed out that the users werent able to see the full search query, Unable to see full search suggestion
By fixing the overflow you introduce the issue i pointed out before
Okay I wasn't aware that was an issue. Was there a decision made about how it should look? This is what is looks like when the text contained and wrapped. Otherwise I guess you can keep the ellipsis cut off but have an alt text/tooltip when hovered over? |
|
This is how it looked before VirtualBoxVM_AOBkZtRQvy.mp4 |
Head branch was pushed to by a user without write access
|
I've removed the ellipsis and adjusted it to look like before. Although I think the icon is a few pixels off, it still looks very similar.
|
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
Head branch was pushed to by a user without write access
github-actions
bot
removed
the
PR: waiting for review
* development: (58 commits) Convert FtSubscribeButton and watch-video-info SCSS to CSS (FreeTubeApp#6814) Use numbers instead of strings for the DBActions and SyncEvents constants (FreeTubeApp#6815) Translated using Weblate (English (United Kingdom)) Fix: search history text overflows if search term is long (FreeTubeApp#6728) Check if a keyboard composition session is active when pressing 'Enter' on ft-input (FreeTubeApp#6799) use hq img (FreeTubeApp#6826) Move the choose default folder logic to the main process (FreeTubeApp#6811) Translated using Weblate (French) Translated using Weblate (Turkish) Set process.platform at build time (FreeTubeApp#6784) Use logical spec for float (FreeTubeApp#6783) Migrate DataSettings to the composition API (FreeTubeApp#6785) Local API: Improve audio quality by sorting streams, highest bitrate first (FreeTubeApp#6807) Bump sass from 1.84.0 to 1.85.0 (FreeTubeApp#6825) Bump webpack from 5.97.1 to 5.98.0 (FreeTubeApp#6820) Bump postcss from 8.5.1 to 8.5.2 in the stylelint group (FreeTubeApp#6819) Bump the babel group with 2 updates (FreeTubeApp#6817) Bump globals from 15.14.0 to 15.15.0 (FreeTubeApp#6823) Bump sass-loader from 16.0.4 to 16.0.5 (FreeTubeApp#6822) Bump eslint from 9.20.0 to 9.20.1 in the eslint group (FreeTubeApp#6818) ... # Conflicts: # src/renderer/components/watch-video-info/watch-video-info.scss # src/renderer/components/watch-video-info/watch-video-info.vue
Fix search history text overflows if search term is long
Pull Request Type
Related issue
closes #6727
Description
Truncates text that exceeds the length of the search history input
Screenshots
Before
After
