VIM Navigation #6797
Open
VIM Navigation #6797
+610
−332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
auto-merge was automatically disabled
February 13, 2025 19:51
Head branch was pushed to by a user without write access
absidue
requested changes
Feb 13, 2025
There was a problem hiding this comment.
Please revert all unrelated changes such as the unnecessary change to the gitignore file and the reformatting to the files. Presumably you have prettier or another plugin enabled in your editor, which is aggressively reformatting the files instead of following FreeTube's code style.
absidue
added
PR: changes requested
and removed
PR: waiting for review
auto-merge was automatically disabled
February 14, 2025 14:26
Head branch was pushed to by a user without write access
|
Adding the work-in-progress label until all of the unrelated code formatting changes are reverted (there are issues with the actual implementation but they aren't worth mentioning until the diff only contains the relevant changes). The diff in GitHub should show no unrelated changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIM Navigation
Pull Request Type
Related issue
#251 (comment)
#1864
Closes #1864
Description
Implements VIM-like key-bindings, similar to Vimium.
Screenshots
Testing
I tested this with basic usage. Navigating to both general and video player keybinding contexts.
Desktop
Additional context
Any conflicting native keybindings will change when vim navigation is enabled. The change will reflect in the keyboard shortcuts modal (Shift + ?). I've yet to implement back and forth page navigation but it should be pretty easy.