Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate stylelintrc to stylint.config.js #6871

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Migrate stylelintrc to stylint.config.js #6871

wants to merge 2 commits into from
+41 −37

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Feb 22, 2025 •
edited by absidue
Loading

Migrate stylelintrc to stylint.config.js

Pull Request Type

  • Other - maintenance/dev chore

Description

This PR migrates the stylelintrc file to a stylelint.config.mjs file. This is now the recommended format for stylelint. https://stylelint.io/user-guide/configure/

We can and probably should still use the .stylelintignore file. See the note here: https://stylelint.io/user-guide/configure/#ignorefiles

Testing

  • make a stylelint "error" in a css and scss file. ex: add a width property instead of inset-size
  • run yarn run lint-style and make sure the error shows

Desktop

  • OS: Fedora Linux
  • OS Version: 41 KDE
  • FreeTube version: latest nightly

@github-actions github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Feb 22, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 22, 2025 01:53
PikachuEXE
PikachuEXE reviewed Feb 22, 2025
View reviewed changes
PikachuEXE
PikachuEXE approved these changes Feb 22, 2025
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw it should be yarn run lint-style not npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue absidue approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChunkyProgrammer @PikachuEXE @absidue