Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes redundant checks from unifier. #6912

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

esdrubal
Copy link
Contributor

Description

unify_structs was also unifying the fields and unify_enums was also unifying the variants.

This was removed because comparing call paths and type parameters is enough.

Fixes #6394

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@esdrubal esdrubal added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Feb 11, 2025
@esdrubal esdrubal self-assigned this Feb 11, 2025
unify_structs was also unifying the fields and
unify_enums was also unifying the variants.

This was removed because comparing call paths and type parameters is enough.

Fixes #6394

Signed-off-by: Marcos Henrich <[email protected]>
@esdrubal esdrubal force-pushed the esdrubal/redundant_unify_checks_6394 branch from 621a504 to 04f71f1 Compare February 11, 2025 10:40
Copy link

codspeed-hq bot commented Feb 11, 2025

CodSpeed Performance Report

Merging #6912 will not alter performance

Comparing esdrubal/redundant_unify_checks_6394 (699f082) with master (bb7c99b)

Summary

✅ 22 untouched benchmarks

@esdrubal esdrubal marked this pull request as ready for review February 11, 2025 10:57
@esdrubal esdrubal requested a review from a team as a code owner February 11, 2025 10:57
@tritao tritao enabled auto-merge (squash) February 11, 2025 13:54
@tritao tritao merged commit 475fd78 into master Feb 11, 2025
40 of 41 checks passed
@tritao tritao deleted the esdrubal/redundant_unify_checks_6394 branch February 11, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant Checks for Struct Equality
3 participants