Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with __transmute type checking #6940

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Feb 18, 2025

Description

This PR solves an issue with __transmute in "const contexts". In these cases, the "source" and "return" types were not being correctly solved.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj self-assigned this Feb 18, 2025
@xunilrj xunilrj requested a review from a team as a code owner February 18, 2025 18:00
Copy link

codspeed-hq bot commented Feb 18, 2025

CodSpeed Performance Report

Merging #6940 will not alter performance

Comparing xunilrj/fix-transmute-type-checking (c8a845c) with master (6de04fc)

Summary

✅ 22 untouched benchmarks

@xunilrj xunilrj added the bug Something isn't working label Feb 18, 2025
@JoshuaBatty JoshuaBatty merged commit 988be9b into master Feb 19, 2025
42 checks passed
@JoshuaBatty JoshuaBatty deleted the xunilrj/fix-transmute-type-checking branch February 19, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants