Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test of never type in arrays #6943

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

jjcnn
Copy link
Contributor

@jjcnn jjcnn commented Feb 20, 2025

Description

Shows that #6387 has been fixed.

This PR adds a few tests of variable initializers that involve type Never. In this case the variable's type ascription should be used instead of the initializer's type.

No changes have been made to the compiler, since the problem that was originally reported was fixed by #6911.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@jjcnn jjcnn added the team:compiler Compiler Team label Feb 20, 2025
@jjcnn jjcnn self-assigned this Feb 20, 2025
@jjcnn jjcnn requested a review from a team as a code owner February 20, 2025 08:57
@IGI-111 IGI-111 requested a review from a team February 20, 2025 16:07
@tritao tritao merged commit b07d0ca into master Feb 20, 2025
40 checks passed
@tritao tritao deleted the jjcnn/never_type_empty_arrays branch February 20, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:compiler Compiler Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants