Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend #[deprecated] support #6944

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extend #[deprecated] support #6944

wants to merge 1 commit into from
+271 −24

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented Feb 20, 2025

Description

Add support for the #[deprecated] attribute to functions, enums, struct items, enum variants and propagate deprecation check exhaustively throughout expressions variants.

Partially addresses #6942.

Support for deprecating traits, abis and the methods thereof in their definitions is still missing, as well as scrutinees and storage fields.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111 IGI-111 added the team:compiler Compiler Team label Feb 20, 2025
@IGI-111 IGI-111 self-assigned this Feb 20, 2025
@IGI-111 IGI-111 requested a review from a team as a code owner February 20, 2025 14:13
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 20, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #6944 will not alter performance

Comparing IGI-111/deprecated (cde768f) with master (fccc8a9)

Summary

✅ 22 untouched benchmarks

@IGI-111 IGI-111 requested a review from a team as a code owner February 24, 2025 13:53
@IGI-111
Extend #[deprecated] support
cde768f 
Add support for the `#[deprecated]` attribute to functions, enums,
struct items, enum variants and propagate deprecation check exhaustively
throughout expressions variants.

Partially addresses #6942.

Support for deprecating traits, abis and the methods thereof in their
definitions is still missing, as well as scrutinees and storage fields.
@IGI-111 IGI-111 requested a review from ironcev February 24, 2025 13:58
@IGI-111 IGI-111 requested a review from a team February 24, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironcev ironcev ironcev approved these changes

@K1-R1 K1-R1 K1-R1 approved these changes

Assignees

@IGI-111 IGI-111

Labels
team:compiler Compiler Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IGI-111 @ironcev @K1-R1