Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Iteration for Bytes #6953

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement Iteration for Bytes #6953

wants to merge 2 commits into from
+167 −0

Conversation

SwayStar123
Copy link
Collaborator

@SwayStar123 SwayStar123 commented Feb 24, 2025 •
edited
Loading

Description

Adds an iterator to allow for loops over bytes

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 marked this pull request as ready for review February 24, 2025 07:48
@SwayStar123 SwayStar123 requested review from a team as code owners February 24, 2025 07:48
bitzoic
bitzoic reviewed Feb 24, 2025
View reviewed changes
sway-lib-std/src/bytes.sw
/// }
/// }
///
/// # Undefined Behavior
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// # Undefined Behavior
/// # Undefined Behavior

This should be addressed, maybe with a clone

sway-lib-std/src/bytes.sw Outdated
// `Iterator` for other types.
//
// Due to the Sway's copy semantics, the `values` will
// actually contain **a copy of the original vector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentences shouldn't start on a newline so forc doc can handle it correctly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are internal comments not docs. I took these from the vector implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitzoic bitzoic bitzoic left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SwayStar123 @bitzoic