Correct inheritFrom usages in Kotlin DSL (#1261)

* Tweak the sample code about using inheritFrom

* Test `canInheritFromOtherManifest`

src/docs/configuration/README.md

@@ -89,15 +89,13 @@ If it is desired to inherit a manifest from a JAR task other than the standard `
 on the `shadowJar.manifest` object can be used to configure the upstream.
 
 ```groovy
-tasks.register('testJar', Jar) {
+def testJar = tasks.register('testJar', Jar) {
   manifest {
     attributes 'Description': 'This is an application JAR'
   }
 }
 
 tasks.named('shadowJar', com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar) {
-  manifest {
-    inheritFrom(project.tasks.testJar.manifest)
-  }
+  manifest.inheritFrom(testJar.get().manifest)
 }
 ```

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/JavaPluginTest.kt

@@ -619,4 +619,33 @@ class JavaPluginTest : BasePluginTest() {
       )
     }
   }
+
+  @Test
+  fun canInheritFromOtherManifest() {
+    projectScriptPath.appendText(
+      """
+        jar {
+          manifest {
+            attributes 'Foo-Attr': 'Foo-Value'
+          }
+        }
+        def testJar = tasks.register('testJar', Jar) {
+          manifest {
+            attributes 'Bar-Attr': 'Bar-Value'
+          }
+        }
+        $shadowJar {
+          manifest.inheritFrom(testJar.get().manifest)
+        }
+      """.trimIndent(),
+    )
+
+    run(shadowJarTask)
+
+    assertThat(outputShadowJar).useAll {
+      transform { it.manifest.mainAttributes }.isNotEmpty()
+      getMainAttr("Foo-Attr").isEqualTo("Foo-Value")
+      getMainAttr("Bar-Attr").isEqualTo("Bar-Value")
+    }
+  }
 }