Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various: add linux support #199822

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SMillerDev
Copy link
Member

@SMillerDev SMillerDev commented Jan 28, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

This shows what is possible after Homebrew/brew#19121

@SMillerDev SMillerDev force-pushed the feat/general/linux_binary branch 2 times, most recently from 9fff9db to c2d26dd Compare January 28, 2025 17:41
@p-linnane p-linnane force-pushed the feat/general/linux_binary branch from c2d26dd to b71e240 Compare January 30, 2025 15:57
@SMillerDev SMillerDev force-pushed the feat/general/linux_binary branch from b71e240 to dc9d3e5 Compare February 9, 2025 11:34
@SMillerDev SMillerDev force-pushed the feat/general/linux_binary branch from dc9d3e5 to 1db9fed Compare February 23, 2025 13:39
@SMillerDev SMillerDev marked this pull request as ready for review February 23, 2025 13:39
@SMillerDev SMillerDev changed the title archy: add linux support various: add linux support Feb 23, 2025
@SMillerDev SMillerDev force-pushed the feat/general/linux_binary branch from 1db9fed to bf6d5f3 Compare February 23, 2025 13:44
@SMillerDev SMillerDev force-pushed the feat/general/linux_binary branch from bf6d5f3 to ef7f4bd Compare February 23, 2025 13:48
@SMillerDev
Copy link
Member Author

It's trying to run archy on ARM. Should we add depends on arch: :x86 to it?

@khipp
Copy link
Member

khipp commented Feb 23, 2025

Does it run on ARM with Rosetta? If so, maybe the checksum could default to the one for Intel architectures?

@SMillerDev
Copy link
Member Author

Does it run on ARM with Rosetta?

The caveat suggests so.

If so, maybe the checksum could default to the one for Intel architectures?

We could, but it seems weird to make the x86 cask have an ARM checksum that's secretly not really ARM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants