Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transform.py #1058

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Update transform.py #1058

wants to merge 2 commits into from

Conversation

ian-cho
Copy link
Collaborator

@ian-cho ian-cho commented Feb 19, 2025

fixed error when contents column is empty

Why are these changes needed?

To handle cases where the contents field may be empty when processing a large number of Parquet files using HAP transform

#1048

fixed error when contents column is empty
Set default to 0 instead of -1 as the model rarely assigns score 0 to any non-empty contents (documents)
Copy link
Member

@shahrokhDaijavad shahrokhDaijavad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after all the good discussion in #1048

@shahrokhDaijavad
Copy link
Member

@touma-I Please merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants