Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

[Infra] Bump to Pydantic v2 #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

philipk19238
Copy link

  • Ran bump-pydantic at repo root

@DanielHougaard
Copy link
Collaborator

DanielHougaard commented Dec 11, 2023

Hi Philip 👋

What was the reason for this bump?
And can you please request a review from me on the PR? :-)

@philipk19238
Copy link
Author

Hi Daniel!

Pydantic v2 introduced many breaking changes that result in Infisical being not compatible with the current versions. This PR has to be made in order to use Infisical with any repo that uses Pydantic versions > 2.

@DanielHougaard
Copy link
Collaborator

Gotcha! And with this version bump, the SDK will remain back-compatible with projects running older versions of Pydantic?

@philipk19238
Copy link
Author

Gotcha! And with this version bump, the SDK will remain back-compatible with projects running older versions of Pydantic?

It should, since its just setting a default None value for Optional fields. Would just have to relax the pydantic version in pyproject.toml

@DanielHougaard
Copy link
Collaborator

It should, since its just setting a default None value for Optional fields. Would just have to relax the pydantic version in pyproject.toml

Cool! If you could please test on older versions of Pydanic just to make sure, that would be great. I'll also have a look in a bit myself :-)

Additionally, please remove the log.txt file from your PR 🙌

@DanielHougaard
Copy link
Collaborator

Hey @philipk19238, just following up on this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants