Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Use GitHub's new rulesets feature instead of branch protections #1309

Closed
3 tasks done
JoshuaKGoldberg opened this issue Feb 15, 2024 · 3 comments · Fixed by #1788
Closed
3 tasks done
Assignees
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Thanks @voxpelli for throwing this my way! https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/creating-rulesets-for-a-repository#creating-a-branch-or-tag-ruleset

Looks like there's API support: https://docs.github.com/en/rest/repos/rules?apiVersion=2022-11-28

Is this something that we should replace the existing branch protection features with?

Additional Info

Co-authored-by: @voxpelli

@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: needs investigation Further research required...? labels Feb 15, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Feb 15, 2024
@JoshuaKGoldberg
Copy link
Owner Author

The feature is looking pretty stable now and seems to have all the parts I need. Plus, unlike classic branch protections, rulesets don't require the branch to already exist. This will be helpful for the create engine onboarding to let the script run before the repository has had its initial commit pushed. I'll take this on now.

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! and removed status: needs investigation Further research required...? labels Dec 19, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🚀 Feature: Investigate GitHub's new rulesets feature instead of branch protections 🚀 Feature: Use GitHub's new rulesets feature instead of branch protections Dec 19, 2024
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @voxpelli for ideas.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @voxpelli! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
1 participant