Fragment arguments validation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
JoviDeCroock
force-pushed
the
fragment-args-typeinfo-2024
branch
from
820ae11 to
870e6e1
Compare
JoviDeCroock
force-pushed
the
fragment-arguments-validation-2024
branch
from
4b77220 to
62f0593
Compare
JoviDeCroock
force-pushed
the
fragment-args-typeinfo-2024
branch
2 times, most recently
from
1190b79 to
1d770fb
Compare
JoviDeCroock
force-pushed
the
fragment-arguments-validation-2024
branch
from
62f0593 to
7fa013e
Compare
JoviDeCroock
force-pushed
the
fragment-args-typeinfo-2024
branch
from
1d770fb to
9de28dc
Compare
JoviDeCroock
force-pushed
the
fragment-arguments-validation-2024
branch
from
7fa013e to
662a925
Compare
JoviDeCroock
force-pushed
the
fragment-args-typeinfo-2024
branch
from
9de28dc to
b422131
Compare
JoviDeCroock
force-pushed
the
fragment-arguments-validation-2024
branch
2 times, most recently
from
960d627 to
febb937
Compare
JoviDeCroock
force-pushed
the
fragment-args-typeinfo-2024
branch
2 times, most recently
from
8754c32 to
2fb5f1d
Compare
JoviDeCroock
force-pushed
the
fragment-arguments-validation-2024
branch
5 times, most recently
from
b378b07 to
59beb56
Compare
* validation suggestions * remove OperationSignature from ValidationContext only used in one rule, does not need to be on context remove dependency on getVariableSignature move FRAGMENT_ARGUMENT below ARGUMENT fragment arguments do not have location defaults only variable defaults => so getDefaultValue(), which returns location defaults for use with the allowedVariableUsage helper, should never be called by getVariableUsages with respect to fragment arguments fragment arguments therefore need not add anything to the default value stack reduce diff from main these diffs crept in before Kind.FRAGMENT_ARGUMENT was separated out
JoviDeCroock
merged commit 32107eb
into
fragment-args-typeinfo-2024
24 of 26 checks passed
JoviDeCroock
added a commit
that referenced
this pull request
Sep 4, 2024
* Add typeinfo functionality as a run-up to supporting the new validation rules Co-authored-by: mjmahone <[email protected]> * Fragment arguments validation (#5) * Fragment args validation * add experimental substitution * validation suggestions (#12) * validation suggestions * remove OperationSignature from ValidationContext only used in one rule, does not need to be on context remove dependency on getVariableSignature move FRAGMENT_ARGUMENT below ARGUMENT fragment arguments do not have location defaults only variable defaults => so getDefaultValue(), which returns location defaults for use with the allowedVariableUsage helper, should never be called by getVariableUsages with respect to fragment arguments fragment arguments therefore need not add anything to the default value stack reduce diff from main these diffs crept in before Kind.FRAGMENT_ARGUMENT was separated out --------- Co-authored-by: Yaacov Rydzinski <[email protected]> * OverlappingFieldsCanBeMergedRule suggestions (#15) --------- Co-authored-by: mjmahone <[email protected]> Co-authored-by: Yaacov Rydzinski <[email protected]>
JoviDeCroock
added a commit
to graphql/graphql-js
that referenced
this pull request
Sep 6, 2024
This is a rebase of #3847 This implements execution of Fragment Arguments, and more specifically visiting, parsing and printing of fragment-spreads with arguments and fragment definitions with variables, as described by the spec changes in graphql/graphql-spec#1081. There are a few amendments in terms of execution and keying the fragment-spreads, these are reflected in mjmahone/graphql-spec#3 The purpose is to be able to independently review all the moving parts, the stacked PR's will contain mentions of open feedback that was present at the time. - [execution changes](JoviDeCroock#2) - [TypeInfo & validation changes](JoviDeCroock#4) - [validation changes in isolation](JoviDeCroock#5) CC @mjmahone the original author --------- Co-authored-by: mjmahone <[email protected]> Co-authored-by: Yaacov Rydzinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements validation for fragment arguments