Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI for glslang broken by latest googletest #2480

Closed
greg-lunarg opened this issue Dec 9, 2020 · 0 comments · Fixed by #2481
Closed

Travis CI for glslang broken by latest googletest #2480

greg-lunarg opened this issue Dec 9, 2020 · 0 comments · Fixed by #2481

Comments

@greg-lunarg
Copy link
Contributor

The current googletest top-of-tree is breaking Travis CI for glslang. See #2472

The googletest problem is documented by issue google/googletest#3128

The googletest problem was introduced by google/googletest@fbef071

There are a number of ways to fix this problem.

  1. hack .travis.yml to checkout a known good version of googletest after cloning it

  2. make googletest part of the glslang known-good.json mechanism. These versions are fetched by update_glslang_sources.py, which is currently called by .travis.yml.

  3. Another is some solution involving submodules. This would be a longer term solution.

#1 is probably the easiest and fastest solution. That is my vote. I will submit a PR shortly if I don't hear any concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant