HLSL: implement 4 (of 6) structuredbuffer types #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkslang
approved these changes
Feb 17, 2017
hlsl/hlslGrammar.cpp
Outdated
| case EHTokRWStructuredBuffer: | ||
| break; | ||
| case EHTokStructuredBuffer: | ||
| readonly = true; |
There was a problem hiding this comment.
Too much columnizing? Not quite seeing logical groupings the need verification by visually seeing the column instead of the row.
| qualifier.storage = type.getQualifier().storage; | ||
| qualifier.readonly = type.getQualifier().readonly; |
There was a problem hiding this comment.
Too many spaces; maybe historical columnizing, but out of place now.
|
I reviewed this, and it looks good to me. Waiting for author removal of WIP. |
This is a partial implemention of structurebuffers supporting: * structured buffer types of: * StructuredBuffer * RWStructuredBuffer * ByteAddressBuffer * RWByteAddressBuffer * Atomic operations on RWByteAddressBuffer * Load/Load[234], Store/Store[234], GetDimensions methods (where allowed by type) * globallycoherent flag But NOT yet supporting: * AppendStructuredBuffer / ConsumeStructuredBuffer types * IncrementCounter/DecrementCounter methods Please note: the stride returned by GetDimensions is as calculated by glslang for std430, and may not match other environments in all cases.
ghost
changed the title
|
Removed columnizing from hlslGrammar, and removed WIP, post real world sanity testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial implemention of structurebuffers supporting:
But NOT yet supporting:
Atomic operations on RWByteAddressBufferNow implementedPlease note # 1: the stride returned by GetDimensions is as calculated per std430, and may not match other environments in all cases.
Please note # 2: the hidden internal counter for Increment/Decrement methods is not in place on RW types. This is also a potential layout difference, until that is implemented.