fix: missing segwit badges #2545

takenagain · 2025-02-21T09:59:40Z

Summary by CodeRabbit

New Features
- Coins are again classified as SegWit based on their identifier (if ticker contains -segwit).
- Activation actions for coins and assets now require authentication, ensuring that these processes only occur for signed-in users. Fixes the failed activation on startup by the Swap form.
- Enhanced fill color handling in text input fields for better UI consistency.

coin activation fails with an error message if there is no wallet/user signed in

coderabbitai · 2025-02-21T09:59:46Z

Walkthrough

The changes introduce updates across three files. In the asset_coin_extension.dart, a new boolean variable (isSegwit) is added to determine if a coin is SegWit based on its ID, which affects the coin mode assignment. In coins_repo.dart, user authentication checks are integrated into the asset and coin activation methods, ensuring that activation only occurs if the user is signed in. The ui_text_form_field.dart file sees the introduction of a local variable for fill color, improving the management of input decoration properties.

Changes

File(s)	Change Summary
lib/bloc/coins_bloc/asset_coin_extension.dart	Added `isSegwit` variable to determine coin mode based on coin ID substring (`'-segwit'`); assigns `CoinMode.segwit` if true, `CoinMode.standard` otherwise; includes a comment and a TODO note.
lib/bloc/coins_bloc/coins_repo.dart	Introduced authentication checks in `activateAssetsSync` and `activateCoinsSync`; if the user is not signed in, logs a message and returns early; added specific error logging for coin activation.
packages/komodo_ui_kit/lib/src/inputs/ui_text_form_field.dart	Introduced `fillColor` variable in `_UiTextFormFieldState` to manage input decoration color; updated `InputDecoration` to use `fillColor` instead of `widget.fillColor`.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as Coin Creator
    participant Ext as AssetCoinExtension
    Note over Ext: Determine coin mode based on coin ID
    Caller->>Ext: Provide coin ID
    Ext->>Ext: Check if coin ID (lowercase) contains "-segwit"
    alt Contains "-segwit"
        Ext->>Caller: Return CoinMode.segwit
    else
        Ext->>Caller: Return CoinMode.standard
    end

sequenceDiagram
    participant Caller as Activation Caller
    participant Repo as CoinsRepo
    participant Auth as Authentication SDK
    Caller->>Repo: Call activateCoinsSync()/activateAssetsSync()
    Repo->>Auth: Call isSignedIn()
    Auth-->>Repo: Return authentication status
    alt Not signed in
        Repo->>Caller: Log skip message and exit activation
    else Signed in
        Repo->>Repo: Proceed with activation process
    end

Poem

I'm a rabbit with a coding knack,
Hopping through logic without looking back.
Coins now check for "-segwit" in their name,
And activations wait for sign-in to be tame.
With logs and checks, our code is tight—
A bunny's delight in a world so bright! 🐰

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9560437 and 004734c.

📒 Files selected for processing (1)

packages/komodo_ui_kit/lib/src/inputs/ui_text_form_field.dart (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: build_and_preview
GitHub Check: validate_code_guidelines

🔇 Additional comments (2)

packages/komodo_ui_kit/lib/src/inputs/ui_text_form_field.dart (2)

226-226: LGTM! Good variable extraction.

The introduction of the fillColor variable improves code readability by centralizing the fill color logic and following Flutter's theme handling best practices.

267-268: LGTM! Consistent fill color handling.

The updates to fillColor and filled properties maintain proper synchronization, ensuring the text field is only filled when a color is specified.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

takenagain · 2025-02-21T10:00:48Z

@coderabbitai review

coderabbitai · 2025-02-21T10:00:57Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

github-actions · 2025-02-21T10:03:43Z

Visit the preview URL for this PR (updated for commit 004734c):

https://walletrc--pull-2545-merge-bv4swewi.web.app

_{(expires Fri, 28 Feb 2025 11:28:37 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

fixes the lacking contrast with the input fields, as a lack of fill colour results in an input field with the same colour as the background (dark and light modes)

takenagain · 2025-02-21T11:25:25Z

@coderabbitai review

coderabbitai · 2025-02-21T11:25:35Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

ShantanuSharma9873 · 2025-02-23T14:59:14Z

The Segwit tag is visible for the coins. Also, the Add Button placement has been changed. The Coin's address can be directly copied from the dropdown directly. Working Properly

takenagain added 2 commits February 20, 2025 20:56

fix(asset): add missing segwit flag to coin conversion function

da22913

fix(activation): skip coin activation if not signed in

9560437

coin activation fails with an error message if there is no wallet/user signed in

takenagain added the bug Something isn't working label Feb 21, 2025

takenagain self-assigned this Feb 21, 2025

fix(text-form-field): add a default fill colour to UiTextFormField

004734c

fixes the lacking contrast with the input fields, as a lack of fill colour results in an input field with the same colour as the background (dark and light modes)

takenagain marked this pull request as ready for review February 21, 2025 11:29

takenagain requested review from AndrewDelaney, smk762, CharlVS and ShantanuSharma9873 February 21, 2025 11:30

This was linked to issues Feb 21, 2025

Segwit badges missing #2538

Closed

Input fields lack contrast #2539

Closed

CharlVS approved these changes Feb 22, 2025

View reviewed changes

CharlVS merged commit 8fa543a into dev Feb 22, 2025
3 of 7 checks passed

This was referenced Feb 24, 2025

Input fields lack contrast #2539

Closed

Segwit badges missing #2538

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: missing segwit badges #2545

fix: missing segwit badges #2545

takenagain commented Feb 21, 2025 •

edited

Loading

coderabbitai bot commented Feb 21, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

takenagain commented Feb 21, 2025

coderabbitai bot commented Feb 21, 2025

github-actions bot commented Feb 21, 2025 •

edited

Loading

takenagain commented Feb 21, 2025

coderabbitai bot commented Feb 21, 2025

ShantanuSharma9873 commented Feb 23, 2025

fix: missing segwit badges #2545

fix: missing segwit badges #2545

Conversation

takenagain commented Feb 21, 2025 • edited Loading

Summary by CodeRabbit

coderabbitai bot commented Feb 21, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

takenagain commented Feb 21, 2025

coderabbitai bot commented Feb 21, 2025

github-actions bot commented Feb 21, 2025 • edited Loading

takenagain commented Feb 21, 2025

coderabbitai bot commented Feb 21, 2025

ShantanuSharma9873 commented Feb 23, 2025

takenagain commented Feb 21, 2025 •

edited

Loading

coderabbitai bot commented Feb 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Feb 21, 2025 •

edited

Loading