cggmp24 development #123
Draft
cggmp24 development #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the branch in which we will work on updating implementation to the latest revision of CGGMP paper Signed-off-by: Denis Varlakov <[email protected]>
|
@maurges does the plan looks okay? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Sounds reasonable. We can even do the moving of zk-proofs here before starting to work on cggmp24. I'm not sure we want to rename just the repo. I think the old repo name should stay in some form (didn't we have enough problems with branches disappearing, imagine a whole repo). Maybe we could rename the repo and make a fork under the old name, and immediately archive it |
|
I don't anticipate any problems, as github will be redirecting old urls, so even if we have git dependencies (I don't think we do), they will get resolved with new url automatically |
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
It's not guaranteed it will do, it even says so when you rename a repo |
But it does it, e.g. https://github.com/LFDT-Lockness/slip-10 still redirects to the new repo. The new release is going to be a breaking change, so it's okay even if git deps get broken |
Signed-off-by: Denis Varlakov <[email protected]>
|
It does redirect, but it's not guaranteed that it will do and do it forever
That's why I'm saying we should put an old version on the old URL |
I see. Yes it would be nice, but I want the repo name to reflect the crate name, and I don't want to keep the old one just to keep projects who use cggmp21 as git dependency intact. |
Upload `paillier-zk`
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Signed-off-by: Denis Varlakov <[email protected]>
Merge `m` into `cggmp24/m`
Crate direct depsDirect depsCompared to base branchDiffAll depscargo treeCompared to base branchDiff |
|
The spec was successfully compiled. PDF is available here. |
Benchmark ResultBenchmarks |
|
@maurges just to add to this discussion: actually, we have already changed repo URL in the past, when we migrated from dfns org to LFDT, so why not doing it again? I don't see how anybody could reasonably expect stability from git dependencies... |
Signed-off-by: Denis Varlakov <[email protected]>
Update cggmp24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the branch in which we will work on updating implementation to the latest revision of CGGMP paper.
Note that
cggmp24/mis protected branch, as well asmit requires a PR for any modification.Upgrade plan:
paillier-zkrepo into the cggmp repocggmp24cggmp24namecggmp21/mprotected branch reserved for security patches