Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcec: update to libcec-next #4283

Merged
merged 5 commits into from
Jun 17, 2020
Merged

libcec: update to libcec-next #4283

merged 5 commits into from
Jun 17, 2020

Conversation

MilhouseVH
Copy link
Contributor

Replacement for #4282. Will track the development branch until there is a new release.

@MilhouseVH
Copy link
Contributor Author

PR380 has now merged upstream. but presumably we still only want to enable HAVE_LINUX_API for Allwinner/Amlogic/Rockchip (at this time)? With #4288 we'll be adding RPi to that list - what's the reason for continuing to disable it on Generic? @Kwiboo @HiassofT

@lrusak
Copy link
Member

lrusak commented Apr 2, 2020

PR380 has now merged upstream. but presumably we still only want to enable HAVE_LINUX_API for Allwinner/Amlogic/Rockchip (at this time)? With #4288 we'll be adding RPi to that list - what's the reason for continuing to disable it on Generic? @Kwiboo @HiassofT

@MilhouseVH we don't enable the CEC media API on the Generic kernel. If you want to use the HAVE_LINUX_API then you'll need to enable the corresponding kernel config items.

@MilhouseVH
Copy link
Contributor Author

If you want to use the HAVE_LINUX_API then you'll need to enable the corresponding kernel config items.

Is that something worth investigating? Any expected benefits (other than consistency)? I don't really have any CEC capable hardware so can't test anything myself. CEC is pretty much voodoo to me...!

@bdutro
Copy link

bdutro commented Apr 17, 2020

FWIW, it seems like CEC support is enabled by default in the Generic kernel. I plugged in a USB-C -> HDMI adapter with CEC passthrough and it creates a /dev/cec0 device. Then I made a side build of libcec and ran it on my LibreELEC box and got this output:

libCEC version: 4.0.4,  compiled on 2020-04-17 22:50:35 by root@3711c0b86ecf on Linux 5.6.4-arch1-1 (x86_64), features: P8_USB, DRM, P8_detect, randr, Linux
Found devices: 1

device:              1
com port:            Linux
vendor id:           0000
product id:          0000
firmware version:    0
type:                Linux

@bdutro
Copy link

bdutro commented Apr 18, 2020

I did a custom Generic build of LIbreelec with CEC_FRAMEWORK_SUPPORT="yes" and I can confirm that CEC is working well.

Copy link

@useful64 useful64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, the use of version libCEC 5.0.0 could be reviewed.

On the libcec webpage it says that Kodi 18.x is not compatible, but I do not know if with Kodi 19.x.

@MilhouseVH MilhouseVH marked this pull request as ready for review May 15, 2020 19:27
@MilhouseVH
Copy link
Contributor Author

No further updates for this PR.

@CvH CvH merged commit 89db20a into LibreELEC:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants