[FEATURE] Allow for status checks to non-HTTPS content #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for dashy-dev ready! 🔨 Explore the source changes: f343af3 🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/6128083e6e597b000756390d 😎 Browse the preview: https://deploy-preview-182--dashy-dev.netlify.app/ |
|
Changes preview: |
|
✔️ Deploy Preview for dashy-dev ready! 🔨 Explore the source changes: ff663f8 🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/61294206bfebbd00076e7b92 😎 Browse the preview: https://deploy-preview-182--dashy-dev.netlify.app/ |
|
Still to do
🌃 Will finish this tomorrow evening... |
asterling8516
pushed a commit
to asterling8516/dashy
that referenced
this pull request
Nov 23, 2023
Closes Lissy93#182 Signed-off-by: Bjorn Lammers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Feature
Overview
By default, requests to insecure or non-HTTPS content should be blocked. This will likely cause the status check to fail. This PR adds an option for the user to disable this security measure for an individual endpoint, if they trust it. This is done by setting
statusCheckAllowInsecure: trueAlso:
Issue Number #181
New Vars (if applicable)
item[n].statusCheckAllowInsecure- Optionalboolean- If set totrue, then security checking is disabled.Screenshot N/A
Code Quality Checklist (Please complete)