Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_record_type for dict record types #88

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Conversation

joelghill
Copy link
Contributor

@joelghill joelghill commented Jul 14, 2023

closes #87

I haven't run into an issue with this code as is, however I noticed what looks like a bug so I thought I would just submit a fix.

@MarshalX
Copy link
Owner

MarshalX commented Jul 15, 2023

pls check this fix suggestion #87 (comment)

@MarshalX MarshalX changed the title Fix to "is_record_type" potentially failing with dict record types Fix is_record_type for dict record types Jul 16, 2023
@MarshalX MarshalX merged commit aac790a into MarshalX:main Jul 16, 2023
@MarshalX
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v0.17.0] - Check for record type will likely fail for dict records
2 participants