Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-migration cleanup for @metamask/json-rpc-engine #1981

Closed
9 of 10 tasks
MajorLift opened this issue Nov 3, 2023 · 2 comments · Fixed by #2011 or #2014
Closed
9 of 10 tasks

Post-migration cleanup for @metamask/json-rpc-engine #1981

MajorLift opened this issue Nov 3, 2023 · 2 comments · Fixed by #2011 or #2014
Assignees
@MajorLift
Labels
enhancement New feature or request team-wallet-framework

Comments

@MajorLift
Copy link
Contributor

MajorLift commented Nov 3, 2023 •
edited
Loading

Tasks

References
@MajorLift MajorLift self-assigned this Nov 3, 2023
This was referenced Nov 7, 2023
Merged
Merged
MajorLift added a commit that referenced this issue Nov 7, 2023
@MajorLift
Update @metamask/json-rpc-engine README to reflect migration into m…
9342a1a 
…onorepo subpackage (#1990)

## Explanation

Adds an "Installation" and "Contributing" section to the `@metamask/json-rpc-engine` README, as it has been migrated into the monorepo.

In future migrations, this step will be performed in "Phase B" (see #1551 (comment)), while the package is being staged in the `merged-packages/` temporary directory.

## References

- Partially implements #1981.

## Changelog

N/A
@MajorLift MajorLift mentioned this issue Nov 7, 2023
Closed
MajorLift added a commit that referenced this issue Nov 7, 2023
@MajorLift
Update root README dependency graph with `@metamask/json-rpc-{engine,…
19be7ca 
…middleware-stream}` (#1991)

## Explanation

- Updating root README dependency graph to reflect
`@metamask/json-rpc-engine` and `@metamask/json-rpc-middleware-stream`
migrations.

## References

- Partially implements #1981
- Partially implements #1982

## Changelog

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
@MajorLift MajorLift mentioned this issue Nov 7, 2023
Merged
6 tasks
@desi
Copy link
Contributor

desi commented Nov 8, 2023

@MajorLift This issue doesn't have an estimate. Is that on purpose?

@MajorLift
Copy link
Contributor Author

MajorLift commented Nov 8, 2023 •
edited
Loading

@desi Just added an estimate for all "post-migration cleanup" tickets!

MajorLift added a commit that referenced this issue Nov 8, 2023
@MajorLift @mcmire
Record CHANGELOG entries from `@metamask/json-rpc-{engine,middleware-…
f647ce0 
…stream}` migrations (#2003)

## Explanation

Records CHANGELOG entries from `@metamask/json-rpc-engine` and
`@metamask/json-rpc-middleware-stream` migrations under "Unreleased"
headers for reference during the next version release.

- [x] Records updates made to the `@metamask/json-rpc-engine` and
`@metamask/json-rpc-middleware-stream` packages since its last release,
and during the migration process.
- [x] Lists these migrations as ADDED changes.
- [x] Records version bumps of the migrated packages in downstream
repos.
- ~Records changes made to downstream repos.~

## References

- Partially implements #1981
- Partially implements #1982

## Changelog

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate

---------

Co-authored-by: Elliot Winkler <[email protected]>
@MajorLift MajorLift mentioned this issue Nov 8, 2023
Merged
3 tasks
MajorLift added a commit that referenced this issue Nov 8, 2023
@MajorLift
Release 90.0.0 (#2011)
be3a48f 
## Explanation

- Releases newly migrated packages:
  - `@metamask/eth-json-rpc-provider`
  - `@metamask/json-rpc-engine`
  - `@metamask/json-rpc-middleware-stream`

- Includes patch releases for version bumps in downstream packages.
- Treated migration as minor version change.

## References

- Partially implements #1842
- Closes #1981
- Closes #1982

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
@MajorLift MajorLift mentioned this issue Nov 8, 2023
Merged
3 tasks
MajorLift added a commit that referenced this issue Nov 8, 2023
@MajorLift
Release 90.0.0 (#2014)
20054ab 
## Explanation

- Releases newly migrated packages:
  - `@metamask/eth-json-rpc-provider`
  - `@metamask/json-rpc-engine`
  - `@metamask/json-rpc-middleware-stream`

- Includes patch releases for version bumps in downstream packages.
- Treated migration as minor version change.

## References

- Partially implements #1842
- Closes #1981
- Closes #1982

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MajorLift MajorLift

Labels
enhancement New feature or request team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 90.0.0 MetaMask/core
Release 90.0.0 MetaMask/core
2 participants
@desi @MajorLift