Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misaligned mock eth query types in controller tests #2036

Closed
MajorLift opened this issue Nov 14, 2023 · 0 comments · Fixed by #2037
Closed

Fix misaligned mock eth query types in controller tests #2036

MajorLift opened this issue Nov 14, 2023 · 0 comments · Fixed by #2037
Assignees
@MajorLift
Labels
team-wallet-framework

Comments

@MajorLift
Copy link
Contributor

Fix 29 // @ts-expect-error Mock eth query does not fulfill type requirements annotations from core.
@MajorLift MajorLift self-assigned this Nov 14, 2023
@MajorLift MajorLift mentioned this issue Nov 14, 2023
Merged
3 tasks
MajorLift added a commit that referenced this issue Nov 15, 2023
@MajorLift
Fix misaligned mock eth query types in controller tests (#2037)
5f62ad4 
## Explanation

Fixes `// @ts-expect-error Mock eth query does not fulfill type
requirements` annotations throughout core repo.

## References

- Builds upon
  - MetaMask/eth-query#21
  - #2028
- Related #1823
- Closes #2036

## Changelog

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MajorLift MajorLift

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix misaligned mock eth query types in controller tests MetaMask/core
1 participant
@MajorLift