Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenList unsafely handles potentially undefined return type #542

Closed
kumavis opened this issue Jul 27, 2021 · 2 comments
Closed

TokenList unsafely handles potentially undefined return type #542

kumavis opened this issue Jul 27, 2021 · 2 comments
Labels
bug Something isn't working team-wallet-framework

Comments

@kumavis
Copy link
Member

kumavis commented Jul 27, 2021

@kumavis
Copy link
Member Author

kumavis commented Jul 27, 2021

typescript failing to save us bc typecasting
does typescript have templating/abstract types?

safelyExecute<Token[]>(() => ...)

or something crazier like

async function safelyExecuteWithTimeout(operation T) returnTypeOf(T) {...}

@Gudahtt Gudahtt added the bug Something isn't working label Nov 4, 2021
@desi
Copy link
Contributor

desi commented Nov 14, 2024

We should stop the use of this function so we will close this one and #543 will cover it.

@desi desi closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team-wallet-framework
Projects
None yet
Development

No branches or pull requests

3 participants