Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excessive use of safelyExecute #543

Open
kumavis opened this issue Jul 28, 2021 · 2 comments
Open

excessive use of safelyExecute #543

kumavis opened this issue Jul 28, 2021 · 2 comments
Labels

Comments

@kumavis
Copy link
Member

kumavis commented Jul 28, 2021

should be used sparingly, eg only by polling handlers

@kumavis
Copy link
Member Author

kumavis commented Jul 28, 2021

additionally its used unsafely in some places, expecting a return value and not tolerating undefined

@Gudahtt
Copy link
Member

Gudahtt commented Jul 29, 2021

Even polls shouldn't ignore all errors, if we can help it anyway. Ideally we'd catch and log expected errors like network problems, and throw unexpected ones that could indicate a problem with our code.

Ignoring all errors makes sense if we expect errors and can't anticipate what they will be (e.g. when dealing with custom networks). It seems unavoidable in that case. But for known APIs we should be able to identify all expected errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants