Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @metamask/utils #1729

Closed
wants to merge 2 commits into from
Closed

Update @metamask/utils #1729

wants to merge 2 commits into from

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Sep 26, 2023

Explanation

Updates @metamask/utils to ^8.1.0 in all subrepos.

References

Changelog

CHANGED: Bump @metamask/utils from ^6.2.0 to ^8.1.0

  • @metamask/accounts-controller
  • @metamask/address-book-controller
  • @metamask/approval-controller
  • @metamask/assets-controller
  • @metamask/base-controller
  • @metamask/controller-utils
  • @metamask/ens-controller
  • @metamask/gas-fee-controller
  • @metamask/keyring-controller
  • @metamask/message-manager
  • @metamask/network-controller
  • @metamask/notification-controller
  • @metamask/permission-controller
  • @metamask/signature-controller
  • @metamask/transaction-controller

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Comment on lines 9 to 13
export const getPermissionsHandler: PermittedHandlerExport<
GetPermissionsHooks,
undefined,
[],
PermissionConstraint[]
> = {
Copy link
Contributor Author

@MajorLift MajorLift Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an empty array here to replace undefined as the empty type resolves the compiler errors, but I'd appreciate input on whether this compromises type safety or might cause issues down the road.

@socket-security
Copy link

socket-security bot commented Sep 26, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@socket-security
Copy link

socket-security bot commented Sep 26, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@MajorLift MajorLift force-pushed the 230926-update-@metamask/utils branch from 720ecc3 to 747e2e9 Compare September 26, 2023 21:42
@MajorLift MajorLift marked this pull request as ready for review September 26, 2023 21:52
@MajorLift MajorLift requested review from a team as code owners September 26, 2023 21:52
@MajorLift MajorLift self-assigned this Sep 26, 2023
@MajorLift MajorLift added dependencies Pull requests that update a dependency file team-wallet-framework labels Sep 26, 2023
@legobeat
Copy link
Contributor

Closing as duplicate of #1639

@legobeat legobeat closed this Sep 27, 2023
@MajorLift MajorLift deleted the 230926-update-@metamask/utils branch October 17, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants