Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 123.0.0 #3997

Closed
wants to merge 3 commits into from
Closed

Release 123.0.0 #3997

wants to merge 3 commits into from

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Feb 29, 2024 •
edited by matthewwalsh0
Loading

This is a release PR for the following packages:

  • @metamask/keyring-controller
  • @metamask/preferences-controller
  • @metamask/assets-controller
  • @metamask/accounts-controller
  • @metamask/user-operation-controller
  • @metamask/signature-controller
  • @metamask/transaction-controller

@mikesposito mikesposito reopened this Feb 29, 2024
@mikesposito mikesposito changed the base branch from main to release/122.0.0 February 29, 2024 12:26
Base automatically changed from release/122.0.0 to main February 29, 2024 20:53
@mikesposito mikesposito marked this pull request as ready for review March 1, 2024 12:07
@mikesposito mikesposito requested a review from a team as a code owner March 1, 2024 12:07
@mcmire
Copy link
Contributor

mcmire commented Mar 1, 2024 •
edited
Loading

I spoke with @mikesposito today and he said that because we already had an existing release branch open, he didn't use create-release-branch to create this PR but rather created it manually. With the other release PR merged, I was able to run it, however. It revealed that due to dependencies / peer dependencies, we may also need to release the following packages:

  • @metamask/base-controller
  • @metamask/approval-controller
  • @metamask/controller-utils
  • @metamask/gas-fee-controller
  • @metamask/logging-controller
  • @metamask/message-manager
  • @metamask/network-controller
  • @metamask/polling-controller

We would need to check over these to see if there are any we could reasonably omit or any that we should include.

I will try to recreate this PR today with new updates. If I don't have time for it though, then we should try to see if we can do this on Monday.

@mcmire mcmire mentioned this pull request Mar 1, 2024
Merged
@mcmire
Copy link
Contributor

mcmire commented Mar 1, 2024

Okay, I've created #4007 which supercedes this one. It includes the packages listed here as well as the ones I mentioned above (minus @metamask/base-controller, which is safe to ignore). I will mark this PR as DO-NOT-MERGE so it's still visible.

@mikesposito
Copy link
Member Author

@mcmire Thanks for checking! I'll close this one then

@mikesposito mikesposito closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DO-NOT-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikesposito @mcmire @matthewwalsh0