-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add destroy
method to block tracker classes
#106
Merged
Merged
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
cee7443
Rewrite tests using Jest
mcmire cb17ef7
ok
mcmire 2da319c
wip
mcmire 074399c
wip - finish fixing SubscribeBlockTracker
mcmire 5518187
Address coverage for PollingBlockTracker
mcmire d0a133c
Fix subscribe tests and achieve 100% coverage
mcmire a86b143
Clean some things up
mcmire 0122100
Clean up one more thing
mcmire 6dd5051
And one more
mcmire 130aabe
Shorten some test names
mcmire a28d74e
Finally get up to 100% coverage
mcmire aaa6a79
Rename some more tests
mcmire 732bdd7
More test names
mcmire 5229e84
remove explicit config for setupAfterEnv.ts
mcmire c475715
Ignore coverage for BaseBlockTracker constructor arguments
mcmire 610f4b4
Update .eslintrc.js
mcmire b8909a4
Remove commented-out thresholds
mcmire 32ea121
note
mcmire b9a0390
Update tsconfig.build.json
mcmire d315b12
Copy new tsconfig.json and tsconfig.build.json from the upcoming modu…
mcmire 2f4bb6d
Change the 'build' command to use tsconfig.build.json
mcmire c93e930
Don't export BaseBlockTracker
mcmire 0ea5a8f
Make BaseBlockTracker an abstract class (only for semantics)
mcmire db013cd
Also call super in SubscribeBlockTracker's _start
mcmire b5caa50
Change _start and _end to abstract methods
mcmire 26bbead
Move inlineSources and sourceMap to build file, exclude dist/ by default
mcmire 1139302
Update tsconfig.json to match module template
mcmire 710e45a
Update src/PollingBlockTracker.ts
mcmire c3e20c9
Respond to more feedback
mcmire 46b50aa
No need to pass originalSetTimeout in
mcmire 1e0434a
Fix lint errors
mcmire d9efdd6
Use ECMA private fields
mcmire 5d8e7b3
Make this a private method
mcmire c127002
Remove the call before calling it
mcmire ec4a03e
Fix copypasta w/ methodToAddListener
mcmire ff6da12
Add `destroy` method to block tracker classes
mcmire 2f0b9b2
[TEMP] Add dist/ for testing
mcmire 26be231
Make this test better
mcmire 797fdc3
Adjust this test name
mcmire ab8e7b4
Add misisng 'methodToAddListener'
mcmire 65594f4
Add missing 'methodToGetLatestBlock'
mcmire a3bf8ed
Tweak more test names
mcmire 57d0b84
thrownError -> thrownString (in cases where it's a string)
mcmire d716aee
Merge branch 'main' into convert-to-jest
Gudahtt c627eae
Revert "[TEMP] Add dist/ for testing"
mcmire 56b75f8
Copy over doc update from other branch
mcmire 34750b4
Merge branch 'convert-to-jest' into add-destroy
mcmire d678c35
Merge branch 'main' into add-destroy
mcmire 7d956e6
Cancel first, then end
mcmire 591b213
Address the same issues with the unclear test as in the other PR
mcmire a004c19
Fix linting error
mcmire File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this come before
this._maybeEnd()
?_maybeEnd()
might take some time to resolve for theSubscribeBlockTracker
, because of theeth_unsubscribe
call.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good call. Fixed in 7d956e6.