Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace DetectTokensController with core monorepo's TokenDetectionController #22928

Merged
merged 42 commits into from
Mar 14, 2024
Merged

refactor: Replace DetectTokensController with core monorepo's TokenDetectionController #22928

Show file tree
Hide file tree
Changes from 36 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
48d93c0
Remove `detect-tokens.js` and test file
MajorLift Mar 8, 2024
f8ba2f5
Bump `@metamask/assets-controllers` to v26, and peerDeps `@metamask/a…
MajorLift Mar 8, 2024
17db540
Update all references to `DetectTokensController` and `detectNewToken…
MajorLift Mar 8, 2024
22c39c1
Remove all references to removed `detect-tokens.{,test.}js
MajorLift Mar 8, 2024
fde07ec
Reapply patches to new accounts-controller, keyring-controller versions
MajorLift Mar 8, 2024
d7fe975
Remove packages unused in develop branch
MajorLift Mar 8, 2024
70d9d70
Add `PreferencesController:stateChange` to tokens-controller allowlist
MajorLift Mar 8, 2024
06d94f5
dedupe lockfile
MajorLift Mar 8, 2024
e36814b
Update allowlist entries for tokens-controller, token-detection-contr…
MajorLift Mar 9, 2024
b507e95
Remove unused constructor options in token-detection-controller insta…
MajorLift Mar 9, 2024
8048e03
Add preferences-controller getState action handler, stateChange subsc…
MajorLift Mar 9, 2024
a2fe4ce
Update accounts-controller patch to fix failing unit tests
MajorLift Mar 9, 2024
66c6e9d
Add API callback for `getNetworkClientById` action
MajorLift Mar 9, 2024
052b51b
test: Fix unit test to use messenger pattern for `getNetworkClientByI…
MajorLift Mar 9, 2024
f655b27
Remove unused dep `@metamask/polling-controller`
MajorLift Mar 9, 2024
0c6854f
Apply lavamoat policies with diffs from `check-working-tree` script
MajorLift Mar 9, 2024
466a60c
Bump `@metamask/keyring-controller` to `^13.0.0` and reapply patch
MajorLift Mar 9, 2024
144f436
Bump `@metamask/controller-utils` to `^8.0.4`
MajorLift Mar 9, 2024
500a539
test: fix `keyringController.getAccounts` call count
MajorLift Mar 9, 2024
46827f0
Replace all imports of `toChecksumHexAddress` from `@metamask/control…
MajorLift Mar 9, 2024
12cf087
Register action handler for `TokensController:getState` to `MetamaskC…
MajorLift Mar 10, 2024
ed9859d
Refactor `isClientOpen` setter to call `enable`, `disable` on `tokenD…
MajorLift Mar 10, 2024
a1a20ed
Add empty state object as entry for `TokenDetectionController` in `SE…
MajorLift Mar 10, 2024
08dd6b0
test: Decrement `numberOfMetaswapRequests`
MajorLift Mar 10, 2024
0023df2
Remove unused patches
MajorLift Mar 10, 2024
21c8d29
Edit `@metamask/accounts-controller` patch
MajorLift Mar 10, 2024
484be71
Remove unused diff from `@metamask/accounts-controller` patch
MajorLift Mar 10, 2024
00d5e74
Remove patch for `@metamask/keyring-controller@npm:13.0.0`
MajorLift Mar 10, 2024
cc9d167
Remove patch for `@metamask/keyring-controller@npm:12.2.0`
MajorLift Mar 10, 2024
32bc395
Add TODOs for removing controller-messenger method calls
MajorLift Mar 11, 2024
dc34547
Merge branch 'develop' into 240213-apply-token-detection-controller
MajorLift Mar 12, 2024
56eff3f
Define `preferencesMessenger` and refactor `PreferencesController` to…
MajorLift Mar 12, 2024
4f6a160
[preferences-controller] Replace manual publish calls with subscripti…
MajorLift Mar 13, 2024
1c374f8
Add TODO for preferences-controller migration
MajorLift Mar 13, 2024
d6b48c9
Remove `getNetworkByClientId` API callback
MajorLift Mar 13, 2024
b825ed4
Remove patch for `@metamask/accounts-controller`
MajorLift Mar 13, 2024
5f7ae9d
FIx empty `SENTRY_BACKGROUND_STATE` object for token-detection-contro…
MajorLift Mar 13, 2024
d038ff9
Merge branch 'develop' into 240213-apply-token-detection-controller
MajorLift Mar 13, 2024
127ca1d
Merge branch 'develop' into 240213-apply-token-detection-controller
MajorLift Mar 13, 2024
17dde59
Fix "working tree dirty" error for lavaomat policies
MajorLift Mar 13, 2024
f98cbad
Merge branch 'develop' into 240213-apply-token-detection-controller
MajorLift Mar 14, 2024
0f5db24
Merge branch 'develop' into 240213-apply-token-detection-controller
MajorLift Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,7 @@ module.exports = {
],
excludedFiles: [
'app/scripts/controllers/app-state.test.js',
'app/scripts/controllers/mmi-controller.test.ts',
'app/scripts/controllers/detect-tokens.test.js',
'app/scripts/controllers/mmi-controller.test.js',
'app/scripts/controllers/permissions/**/*.test.js',
'app/scripts/controllers/preferences.test.js',
'app/scripts/lib/**/*.test.js',
Expand Down Expand Up @@ -299,7 +298,6 @@ module.exports = {
'app/scripts/controllers/permissions/**/*.test.js',
'app/scripts/controllers/preferences.test.js',
'app/scripts/lib/**/*.test.js',
'app/scripts/controllers/detect-tokens.test.js',
'app/scripts/metamask-controller.test.js',
'app/scripts/migrations/*.test.js',
'app/scripts/platforms/*.test.js',
Expand Down
1 change: 0 additions & 1 deletion .mocharc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ module.exports = {
'./app/scripts/lib/**/*.test.js',
'./app/scripts/migrations/*.test.js',
'./app/scripts/platforms/*.test.js',
'./app/scripts/controllers/detect-tokens.test.js',
'./app/scripts/controllers/app-state.test.js',
'./app/scripts/controllers/permissions/**/*.test.js',
'./app/scripts/controllers/mmi-controller.test.ts',
Expand Down
88 changes: 0 additions & 88 deletions .yarn/patches/@metamask-accounts-controller-npm-10.0.0-247993ca9a.patch
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions .yarn/patches/@metamask-assets-controllers-npm-24.0.0-dfef136464.patch
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions .yarn/patches/@metamask-keyring-controller-npm-12.2.0-2b196324d1.patch
View file
Open in desktop

This file was deleted.

Loading
Loading