Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Draft implementation of caveat merging #24271

Closed
wants to merge 1 commit into from
Closed

feat: Draft implementation of caveat merging #24271

wants to merge 1 commit into from

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Apr 29, 2024 •
edited by github-actions bot
Loading

A draft implementation of caveat merging using MetaMask/core#4222 and some yet to be published work.

PR template

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

rekmarks
rekmarks commented May 7, 2024
View reviewed changes
app/scripts/controllers/permissions/background-api.js
if (existingAccounts.includes(account)) {
return;
}
const addMoreAccounts = (origin, accountOrAccounts) =>
Copy link
Member Author

@rekmarks rekmarks May 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Check the diff, console.error() on empty.

@rekmarks
Copy link
Member Author

Superseded by #24834

@rekmarks rekmarks closed this May 28, 2024
@rekmarks rekmarks deleted the caveat-merging branch May 28, 2024 17:06
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rekmarks