Parameterize SmartTransactionsController state by ChainId for MultiChain + Integrate PollingController Mixin #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
multichain-refactor-again
branch
from
3729ab4 to
5c467b0
Compare
adonesky1
force-pushed
the
multichain-refactor-again
branch
from
5c467b0 to
5f1df33
Compare
adonesky1
commented
Nov 16, 2023
Comment on lines
-366
to
-371
| const txReceipt = mapValues(transactionReceipt, (value) => { | ||
| if (value instanceof ethersBigNumber) { | ||
| return value.toHexString(); | ||
| } | ||
| return value; | ||
| }); |
There was a problem hiding this comment.
@dan437 so now we don't need to modify the transactionReceipt object since none of the values will be in ethersBigNumber format.
adonesky1
force-pushed
the
multichain-refactor-again
branch
from
745ae58 to
51d52e1
Compare
This was referenced Nov 20, 2023
MajorLift
reviewed
Nov 22, 2023
MajorLift
reviewed
Nov 22, 2023
MajorLift
reviewed
Nov 22, 2023
MajorLift
reviewed
Nov 22, 2023
MajorLift
reviewed
Nov 22, 2023
MajorLift
reviewed
Nov 22, 2023
MajorLift
reviewed
Nov 24, 2023
…ain + Integrate PollingController Mixin (#210) * integrating multichain controller upgrades * add test * cleanup * need to move confirmSmartTransaction tests into another test since confirmSmartTransaction is now private * actually for now leave it as a public method * cleanup * fix typeerror? * add test + cleanup * add a test + bump test coverage * update type * fix type issue * address feedback * fix provider logic * update test coverage threshholds * make a private and public version of updateSmartTransaction * fix capitalization" * addressing feedback * replace @ethersproject/providers with @metamask/eth-query * cleanup * address more feedback * remove @ethersproject/bignumber * make confirmSmartTransaction a private method * remove comment * getTransaction -> getTransactionByHash * fix ethquery mock
adonesky1
force-pushed
the
multichain-refactor-again
branch
from
1b608f2 to
93a05f1
Compare
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @metamask/[email protected] |
|
Looks good from my end! I'll defer to the team for final approval. |
jiexi
reviewed
Nov 29, 2023
jiexi
reviewed
Nov 29, 2023
jiexi
reviewed
Nov 29, 2023
jiexi
reviewed
Nov 29, 2023
jiexi
reviewed
Nov 29, 2023
jiexi
reviewed
Nov 29, 2023
jiexi
reviewed
Nov 29, 2023
jiexi
reviewed
Nov 29, 2023
jiexi
reviewed
Nov 29, 2023
jiexi
reviewed
Nov 29, 2023
jiexi
reviewed
Nov 29, 2023
jiexi
reviewed
Nov 29, 2023
jiexi
reviewed
Nov 29, 2023
|
Going to wait for a review from @dan437 before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:E2E test with extension to ensure working properly before taking out of draftWorking e2e test here:
https://github.com/MetaMask/smart-transactions-controller/assets/34557516/307de2da-1fe3-43c8-8faa-7bf51da28eaa
Resolves: https://github.com/MetaMask/MetaMask-planning/issues/1039
Integrates new
PollingControllerabstraction into theSmartTransactionsController, implements the_executePollmethod and parameterizes theupdateSmartTransactionsmethod bynetworkClientIdsuch that pending SmartTransaction statuses can be polled for concurrently across different chains.A note: As is our current controller refactor strategy, these changes are additive, backwards compatible and coexist alongside the existing globally selected network pattern. Once we fully adopt this polling pattern we should no longer access the root liveness and fees state but rather access these values by chainId from
livenessByChainIdandfeesByChainId.Added
PollingControllermixin into theSmartTransactionsControllerand implements the abstract_executePollmethod.Changed
networkClientIdargument to theupdateSmartTransactionmethod which, if passed, is used fetch the chainId that corresponds to the networkClientId and is then used to fetch and update the status of pending smart transactions for that chainId.