Latest build bug fixes #275

FrederikBolding · 2022-03-10T12:17:18Z

Fixes a number of issues that were found when using the latest build with the Filecoin Snap.

Adds backwards compatibility for versions defined as latest (do we want that?)
Fixes a recently introduced issue with fetching NPM packages via cross-fetch
Fixes a bug where Snaps couldn't be completely removed and got stuck in limbo if you cancelled while being in the process of adding a snap
- This happened because RevokeAllPermissions throws if permissions haven't been added yet

packages/controllers/src/snaps/SnapController.ts

rekmarks

LGTM!

FrederikBolding added 4 commits March 10, 2022 13:09

Add fallback for 'latest' version

bded417

Fix NPM tarball issues with cross-fetch

9116df1

Fix bug with revoking permissions

78fd0b3

Remove unused type

f781b53

Mrtenz reviewed Mar 10, 2022

View reviewed changes

packages/controllers/src/snaps/SnapController.ts Outdated Show resolved Hide resolved

FrederikBolding marked this pull request as ready for review March 10, 2022 13:41

Fix revokeAllSnapPermissions

5916bbf

rekmarks force-pushed the fb/latest-build-bugfixes branch from f126a28 to 5916bbf Compare March 10, 2022 23:00

Fixup

4bc905c

rekmarks previously approved these changes Mar 11, 2022

View reviewed changes

Change type back to JSON

d714db7

FrederikBolding dismissed rekmarks’s stale review via d714db7 March 11, 2022 08:10

FrederikBolding requested a review from rekmarks March 11, 2022 08:11

rekmarks approved these changes Mar 11, 2022

View reviewed changes

Merge branch 'main' into fb/latest-build-bugfixes

9587a64

FrederikBolding merged commit ae60dd0 into main Mar 11, 2022

FrederikBolding deleted the fb/latest-build-bugfixes branch March 11, 2022 08:29

Provide feedback