Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-563: Parameterized test not executed when using typed arrays end ends with invalid success state #563

Closed
MikeSchulze opened this issue Aug 31, 2024 Discussed in #561 · 0 comments · Fixed by #572
Closed

GD-563: Parameterized test not executed when using typed arrays end ends with invalid success state #563

MikeSchulze opened this issue Aug 31, 2024 Discussed in #561 · 0 comments · Fixed by #572
Assignees
@MikeSchulze
Labels
bug Something isn't working
Milestone
v4.4.0

Comments

@MikeSchulze
Copy link
Owner

Discussed in #561

Originally posted by joshuafolkken August 31, 2024
When I add a type to an Array in the test method arguments, the test passes.

result: FAILED (This is the correct result)

func test_a(items: Array, test_parameters := [[[1]]]) -> void:
	assert_bool(true).is_equal(false)

result: PASSED (This is not the correct result)

func test_b(items: Array[int], test_parameters := [[[1]]]) -> void:
	assert_bool(true).is_equal(false)

What should I do?

Environment Details

  • GdUnit4 4.3.4
  • Godot 4.3, stable, Typed GDScript
  • macOS Sonoma 14.6.1
@MikeSchulze MikeSchulze added the bug Something isn't working label Aug 31, 2024
@MikeSchulze MikeSchulze added this to the v4.4.0 milestone Aug 31, 2024
@MikeSchulze MikeSchulze self-assigned this Aug 31, 2024
@MikeSchulze MikeSchulze changed the title Parameterized test ends with success when using typed arrays GD-563: Parameterized test ends with success when using typed arrays Aug 31, 2024
@MikeSchulze MikeSchulze changed the title GD-563: Parameterized test ends with success when using typed arrays GD-563: Parameterized test ends with invalid success state when using typed arrays Aug 31, 2024
@MikeSchulze MikeSchulze changed the title GD-563: Parameterized test ends with invalid success state when using typed arrays GD-563: Parameterized test not executed when using typed arrays end ends with invalid success state Aug 31, 2024
@MikeSchulze MikeSchulze moved this to In Progress in GdUnit4 Sep 16, 2024
MikeSchulze added a commit that referenced this issue Sep 18, 2024
@MikeSchulze
GD-563: Parameterized test not executed when using typed arrays end e…
50efb4f 
…nds with invalid success state

# Why
#563

# What
- simplify scrip parsing
- cleanup script parser
- use suffixed values on doubler to avoid name clashes with arguments
- finally added `fixure_typed_parameters` to convert the test paramater array to typed array if need
@MikeSchulze MikeSchulze mentioned this issue Sep 18, 2024
Merged
@MikeSchulze MikeSchulze linked a pull request Sep 18, 2024 that will close this issue
GD-563: Fix, parameterized test not executed when using typed arrays end ends with invalid success state #572
Merged
MikeSchulze added a commit that referenced this issue Sep 18, 2024
@MikeSchulze
GD-563: Parameterized test not executed when using typed arrays end e…
3dfcba6 
…nds with invalid success state

# Why
#563

# What
- simplify scrip parsing
- cleanup script parser
- use suffixed values on doubler to avoid name clashes with arguments
- finally added `fixure_typed_parameters` to convert the test paramater array to typed array if need
MikeSchulze added a commit that referenced this issue Sep 19, 2024
@MikeSchulze
GD-563: Parameterized test not executed when using typed arrays end e…
dbeec2c 
…nds with invalid success state

# Why
#563

# What
- simplify scrip parsing
- cleanup script parser
- use suffixed values on doubler to avoid name clashes with arguments
- finally added `fixure_typed_parameters` to convert the test paramater array to typed array if need
MikeSchulze added a commit that referenced this issue Sep 19, 2024
@MikeSchulze
GD-563: Parameterized test not executed when using typed arrays end e…
300028c 
…nds with invalid success state

# Why
#563

# What
- simplify scrip parsing
- cleanup script parser
- use suffixed values on doubler to avoid name clashes with arguments
- finally added `fixure_typed_parameters` to convert the test paramater array to typed array if need
MikeSchulze added a commit that referenced this issue Sep 19, 2024
@MikeSchulze
GD-563: Fix, parameterized test not executed when using typed arrays …
00159ba 
…end ends with invalid success state (#572)

# Why
#563

# What
- simplify scrip parsing
- cleanup script parser
- use suffixed values on doubler to avoid name clashes with arguments
- finally added `fixure_typed_parameters` to convert the test parameter
array to typed array if we need
@github-project-automation github-project-automation bot moved this from In Progress to Done in GdUnit4 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeSchulze MikeSchulze

Labels
bug Something isn't working
Projects
GdUnit4
Status: Done
Milestone
v4.4.0
1 participant
@MikeSchulze