-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support configurable left and right message layout #3244
base: master
Are you sure you want to change the base?
Conversation
While I am not against this kind of style option - can I ask as to why? Is this a common style preference available in other tools that you personally like to us? Usually, for things like the,is a better option is:
This PR doesn't have an issue (and it should!) so its hard to gauge if adding this is worth it. Keep in mind after anyone makes a contribution we have to support it forever! |
First of all, thank you @timothycarambat very much for your reply. I have added an issue to let everyone choose whether to use this feature. |
Ah I see now, okay understood. Will review and see what we can do |
ui: refactor alignment UI selector for dark and light mode with simple styling
@MrGaoGang - can you pull in my changes and re-confirm that functionality works as you intended? Did some UI refactors for dark and light mode + prevented rerenders of the hook on every chat message for performance reasons. If all looks good, please reply so and ill merge. My end looks good to me. |
fix: apply chat alignment to homepage chat
@timothycarambat Yes, thanks. I have just tested it and it works fine. Thank you very much for your commit, which makes the project run better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested:
- Desktop
- Mobile
- Light mode
- Dark mode
Pull Request Type
resolves #3253
What is in this change?
In Message List:
Impact on code
Developer Validations
yarn lint
from the root of the repo & committed changes