Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1921 #1922

Merged
merged 2 commits into from
Jul 31, 2017
Merged

Fix #1921 #1922

merged 2 commits into from
Jul 31, 2017

Conversation

pygy
Copy link
Member

@pygy pygy commented Jul 31, 2017 •
edited
Loading

Description

fix for #1921: Don't visit the children array of components, even when the instance is null.

How Has This Been Tested?

npm run test before and after the fix. Fails before (exception thrown because the _state is null), succeeds after.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@pygy pygy requested a review from lhorie as a code owner July 31, 2017 09:41
@pygy pygy requested a review from tivac as a code owner July 31, 2017 09:48
@pygy pygy changed the title Add tests for issue 1921 (onremove fires on childrent that don't end up in the instance) Fix #1921 Jul 31, 2017
dead-claudia
dead-claudia approved these changes Jul 31, 2017
View reviewed changes
Copy link
Member

@dead-claudia dead-claudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. An added bonus is that it's a little more readable, too. 😄 👍

@pygy pygy merged commit 157fb7d into MithrilJS:next Jul 31, 2017
@pygy pygy deleted the fix-1921 branch July 31, 2017 10:17
@pygy
Copy link
Member Author

pygy commented Jul 31, 2017

Thanks @isiahmeadows I was about to add you as a reviewer (the others were added automatically)

@tivac while I don't feel like I "own" any file in the project, I wouldn't mind being automatically added as a reviewer to PRs about the most of the code base...

pygy added a commit to pygy/mithril.js that referenced this pull request Jul 31, 2017
@pygy
Move the MithrilJS#1921/MithrilJS#1922 line into the v1.1.4 change set
423253f
pygy added a commit that referenced this pull request Jul 31, 2017
@pygy
Merge pull request #1923 from pygy/fix-change-log
e53cd52 
Move the #1921/#1922 line into the v1.1.4 change set
@dead-claudia
Copy link
Member

@pygy Just add yourself here to whatever directory suits your fancy. 😉

@dead-claudia
Copy link
Member

You'll need to look here, though.

@tivac
Copy link
Contributor

tivac commented Jul 31, 2017

Yep! No reason to wait for me, just add yourself to whichever things you care about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead-claudia dead-claudia dead-claudia approved these changes

@lhorie lhorie Awaiting requested review from lhorie

@tivac tivac Awaiting requested review from tivac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pygy @dead-claudia @tivac