[sui system] SIP-39 (reroll) #21303
Open
[sui system] SIP-39 (reroll) #21303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damirka
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
damirka
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
damirka
requested review from
sblackshear,
manolisliolios,
rjs-mysten and
dariorussi
damirka
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
damirka
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
reviewed
Feb 21, 2025
| @@ -139,3 +143,9 @@ public fun increment_epoch_number(self: &mut TxContext) { | |||
| public fun increment_epoch_timestamp(self: &mut TxContext, delta_ms: u64) { | |||
| self.epoch_timestamp_ms = self.epoch_timestamp_ms + delta_ms | |||
| } | |||
|
|
|||
| #[test_only] | |||
| public fun set_epoch(self: &mut TxContext, epoch: u64) { | |||
There was a problem hiding this comment.
Should we call this advance_epoch? since it can't go backwards
There was a problem hiding this comment.
We have APIs that should help address this already in test_scenario. I would vote we continue to use those and not build out competing APIs
Comment on lines
+266
to
+272
| if (epoch < start_epoch + phase_length) { // phase 1 | ||
| (12, 8, 4) | ||
| } else if (epoch < start_epoch + (2 * phase_length)) { // phase 2 | ||
| (6, 4, 2) | ||
| } else { // phase 3 | ||
| (3, 2, 1) | ||
| } |
There was a problem hiding this comment.
Nit, do we want {} on the if-else bodies here?
Comment on lines
+421
to
+423
| if (!self.extra_fields.contains(key)) { | ||
| self.extra_fields.add(key, ctx.epoch()); | ||
| }; |
There was a problem hiding this comment.
consider
Suggested change
| if (!self.extra_fields.contains(key)) { | |
| self.extra_fields.add(key, ctx.epoch()); | |
| }; | |
| if (!self.extra_fields.contains(key)) self.extra_fields.add(key, ctx.epoch()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.