switch to NeMo 2.0 recipes #10948

dimapihtar · 2024-10-18T19:34:20Z

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

Signed-off-by: dimapihtar <[email protected]>

nemo/collections/llm/tools/auto_configurator/runner.py

Signed-off-by: dimapihtar <[email protected]>

examples/llm/auto_configurator/auto_config.py

nemo/collections/llm/tools/auto_configurator/core/calculate_performance.py

Signed-off-by: dimapihtar <[email protected]>

pablo-garay · 2024-10-24T21:49:10Z

Approved from CICD perspective

Signed-off-by: dimapihtar <[email protected]>

github-actions · 2024-10-28T17:49:58Z

[🤖]: Hi @dimapihtar 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

* switch to NeMo 2.0 recipes Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * add NeMo 2.0 recipe support Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix unit tests Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix auto conf ci test Signed-off-by: dimapihtar <[email protected]> * remove unused imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix stlye Signed-off-by: dimapihtar <[email protected]> * fix typo Signed-off-by: dimapihtar <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Co-authored-by: dimapihtar <[email protected]>

* switch to NeMo 2.0 recipes Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * add NeMo 2.0 recipe support Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix unit tests Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix auto conf ci test Signed-off-by: dimapihtar <[email protected]> * remove unused imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix stlye Signed-off-by: dimapihtar <[email protected]> * fix typo Signed-off-by: dimapihtar <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Co-authored-by: dimapihtar <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]>

* switch to NeMo 2.0 recipes Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * add NeMo 2.0 recipe support Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix unit tests Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix auto conf ci test Signed-off-by: dimapihtar <[email protected]> * remove unused imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix stlye Signed-off-by: dimapihtar <[email protected]> * fix typo Signed-off-by: dimapihtar <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Co-authored-by: dimapihtar <[email protected]> Signed-off-by: Hainan Xu <[email protected]>

* switch to NeMo 2.0 recipes Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * add NeMo 2.0 recipe support Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix unit tests Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix auto conf ci test Signed-off-by: dimapihtar <[email protected]> * remove unused imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix stlye Signed-off-by: dimapihtar <[email protected]> * fix typo Signed-off-by: dimapihtar <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Co-authored-by: dimapihtar <[email protected]>

dimapihtar and others added 2 commits October 18, 2024 12:33

switch to NeMo 2.0 recipes

788e892

Signed-off-by: dimapihtar <[email protected]>

Apply isort and black reformatting

76e4ddf

Signed-off-by: dimapihtar <[email protected]>

github-advanced-security bot found potential problems Oct 18, 2024

View reviewed changes

nemo/collections/llm/tools/auto_configurator/runner.py Fixed Show fixed Hide fixed

dimapihtar and others added 3 commits October 22, 2024 06:19

Merge branch 'main' into dpykhtar/auto_conf_upgrade

976008f

add NeMo 2.0 recipe support

9a4c695

Signed-off-by: dimapihtar <[email protected]>

Apply isort and black reformatting

d950cc4

Signed-off-by: dimapihtar <[email protected]>

github-advanced-security bot found potential problems Oct 22, 2024

View reviewed changes

examples/llm/auto_configurator/auto_config.py Fixed Show fixed Hide fixed

examples/llm/auto_configurator/auto_config.py Fixed Show fixed Hide fixed

nemo/collections/llm/tools/auto_configurator/core/calculate_performance.py Fixed Show fixed Hide fixed

dimapihtar and others added 4 commits October 23, 2024 11:06

fix unit tests

c65f171

Signed-off-by: dimapihtar <[email protected]>

Apply isort and black reformatting

e5a39c0

Signed-off-by: dimapihtar <[email protected]>

Merge branch 'main' into dpykhtar/auto_conf_upgrade

56dc1a3

fix auto conf ci test

6d43509

Signed-off-by: dimapihtar <[email protected]>

github-actions bot added the CI label Oct 23, 2024

dimapihtar marked this pull request as ready for review October 23, 2024 18:15

dimapihtar requested review from pablo-garay and ko3n1g as code owners October 23, 2024 18:15

dimapihtar and others added 2 commits October 23, 2024 11:17

remove unused imports

51cdaa0

Signed-off-by: dimapihtar <[email protected]>

Apply isort and black reformatting

bb46490

Signed-off-by: dimapihtar <[email protected]>

dimapihtar added the Run CICD label Oct 23, 2024

ericharper requested a review from marcromeyn October 24, 2024 18:50

pablo-garay previously approved these changes Oct 24, 2024

View reviewed changes

Merge branch 'main' into dpykhtar/auto_conf_upgrade

f788acc

dimapihtar dismissed pablo-garay’s stale review via f788acc October 28, 2024 14:19

dimapihtar and others added 3 commits October 28, 2024 16:21

Merge branch 'main' into dpykhtar/auto_conf_upgrade

3612e4c

fix stlye

2b6915d

Signed-off-by: dimapihtar <[email protected]>

fix typo

a685df6

Signed-off-by: dimapihtar <[email protected]>

github-actions bot added the NLP label Oct 28, 2024

ko3n1g approved these changes Oct 28, 2024

View reviewed changes

dimapihtar added Run CICD and removed Run CICD labels Oct 28, 2024

marcromeyn approved these changes Oct 29, 2024

View reviewed changes

dimapihtar merged commit c51cb67 into main Oct 29, 2024
156 of 157 checks passed

dimapihtar deleted the dpykhtar/auto_conf_upgrade branch October 29, 2024 12:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

switch to NeMo 2.0 recipes #10948

switch to NeMo 2.0 recipes #10948

dimapihtar commented Oct 18, 2024

pablo-garay commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024

switch to NeMo 2.0 recipes #10948

switch to NeMo 2.0 recipes #10948

Conversation

dimapihtar commented Oct 18, 2024

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information

pablo-garay commented Oct 24, 2024 • edited Loading

github-actions bot commented Oct 28, 2024

pablo-garay commented Oct 24, 2024 •

edited

Loading