Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed normalization of feature vector and weight vector #12246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

penguinwang96825
Copy link

What does this PR do ?

Fixes the incorrect implementation of the nemo.collections.asr.modules.conv_asr.SpeakerDecoder by ensuring that feature vector and weight normalization is applied correctly. Previously, normalization was applied inside the loop on individual parameters, which led to incorrect cosine similarity values. Now, normalization is applied directly to the feature vector and weight matrix to maintain correct scaling.

Collection: ASR

Changelog

  • Fixed incorrect normalization of weights inside the loop.
  • Applied normalization to the feature vector and weight matrix before computing cosine similarity.
  • Ensured cosine similarity values do not exceed 1.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas. @titu1994, @redoctopus, @jbalam-nv, or @okuchaiev

@github-actions github-actions bot added the ASR label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant