Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu22.04 6.8 kernel support #237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ubuntu22.04 6.8 kernel support #237

wants to merge 1 commit into from

Conversation

shivakunv
Copy link
Contributor

@shivakunv shivakunv commented Feb 18, 2025

Features and Code Changes:

  1. LTS Kernel Matrix: Added support for 5.15 and 6.8 for (ubuntu22.04)

  2. Base Target and LTS KERNEL Version Matrix: Added support for Jammy and Noble.

  3. Hardcoded Values Removed:
    base_target_ubuntu22_04, base_target_ubuntu24_04, and lts_kernel_ubuntu24_04 are now dynamically handled instead of being hardcoded.

  4. Skipped Unsupported Versions:

base_target = noble && dist = ubuntu22.04

base_target = jammy && dist = ubuntu24.04

base_target = noble && lts_kernel = 5.15

driver_branch = 535 && dist = ubuntu24.04

  1. findkernelversion.sh :- kernel version file download change:

Removed downloading of kernel_version.txt from the Docker build-base.
Now, artifacts-based download is considered instead.
Reason: When building the base via make build-base-jammy, it now includes two LTS kernels (Ubuntu 22.04: 5.15 and 6.8). Running a parallel matrix will cause make build-base-jammy to overwrite( 5.15 and 6.8) kernel-version.txt, leading to incorrect values in matrix_values files during download with regctl in determine-e2e-test-matrix job.
Solution: Either modify the Makefile to introduce a new command (make build-base-${base_target}-${lts_kernel}) or directly download kernel_version.txt from artifacts.
Since kernel_version
... files are already being uploaded as artifacts, we now rely on those values._

  1. Artifact Listing Enhancement in findkernelversion.sh:

Added --paginate option in gh Get API for artifact listing to support more than 30 artifacts.

@shivakunv shivakunv self-assigned this Feb 18, 2025
Copy link

copy-pr-bot bot commented Feb 18, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shivakunv shivakunv force-pushed the ubuntu22-kernel6_8 branch 4 times, most recently from 426a01d to b614c45 Compare February 18, 2025 16:21
@shivakunv shivakunv force-pushed the ubuntu22-kernel6_8 branch 7 times, most recently from 5df6735 to 734f789 Compare February 21, 2025 07:21
@shivakunv shivakunv changed the title Not For Review ubuntu22.04 6.8 kernel support Review ubuntu22.04 6.8 kernel support Feb 21, 2025
@shivakunv shivakunv marked this pull request as ready for review February 21, 2025 07:21
@shivakunv shivakunv changed the title Review ubuntu22.04 6.8 kernel support ubuntu22.04 6.8 kernel support Feb 21, 2025
@@ -17,30 +18,20 @@ chmod a+x bin/regctl
export PATH=$(pwd)/bin:${PATH}

# calculate kernel version of latest image
regctl image get-file ghcr.io/nvidia/driver:base-${BASE_TARGET}-${KERNEL_FLAVOR}-${DRIVER_BRANCH} /var/kernel_version.txt ./kernel_version.txt 2>/dev/null || true
Copy link
Contributor Author

@shivakunv shivakunv Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed downloading of kernel_version.txt from the Docker base.
Now, artifacts-based download is considered instead.
Reason: When building the base via make build-base-jammy, it now includes two LTS kernels (Ubuntu 22.04: 5.15 and 6.8). Running a parallel matrix will cause make build-base-jammy to overwrite( 5.15 and 6.8) kernel-version.txt, leading to incorrect values in matrix_values files during download with regctl in determine-e2e-test-matrix job.
Solution: Either modify the Makefile to introduce a new command (make build-base-${base_target}-${lts_kernel}) or directly download kernel_version.txt from artifacts.
Since kernel_version... files are already being uploaded as artifacts, we now rely on those values._

fi
prefix="kernel-version-${DRIVER_BRANCH}-${LTS_KERNEL}"
suffix="${kernel_flavor}-${DIST}"
artifacts=$(gh api -X GET /repos/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}/artifacts --paginate --jq '.artifacts[].name')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paginate option in gh Get API for artifact listing to support more than 30 artifacts.

@ArangoGutierrez
Copy link
Collaborator

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants