-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ubuntu22.04 6.8 kernel support #237
base: main
Are you sure you want to change the base?
Conversation
426a01d
to
b614c45
Compare
5df6735
to
734f789
Compare
@@ -17,30 +18,20 @@ chmod a+x bin/regctl | |||
export PATH=$(pwd)/bin:${PATH} | |||
|
|||
# calculate kernel version of latest image | |||
regctl image get-file ghcr.io/nvidia/driver:base-${BASE_TARGET}-${KERNEL_FLAVOR}-${DRIVER_BRANCH} /var/kernel_version.txt ./kernel_version.txt 2>/dev/null || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed downloading of kernel_version.txt from the Docker base.
Now, artifacts-based download is considered instead.
Reason: When building the base via make build-base-jammy, it now includes two LTS kernels (Ubuntu 22.04: 5.15 and 6.8). Running a parallel matrix will cause make build-base-jammy to overwrite( 5.15 and 6.8) kernel-version.txt, leading to incorrect values in matrix_values files during download with regctl in determine-e2e-test-matrix job.
Solution: Either modify the Makefile to introduce a new command (make build-base-${base_target}-${lts_kernel}) or directly download kernel_version.txt from artifacts.
Since kernel_version... files are already being uploaded as artifacts, we now rely on those values._
fi | ||
prefix="kernel-version-${DRIVER_BRANCH}-${LTS_KERNEL}" | ||
suffix="${kernel_flavor}-${DIST}" | ||
artifacts=$(gh api -X GET /repos/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}/artifacts --paginate --jq '.artifacts[].name') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paginate option in gh Get API for artifact listing to support more than 30 artifacts.
/ok to test |
Signed-off-by: shiva kumar <[email protected]>
734f789
to
56e6fc4
Compare
Features and Code Changes:
LTS Kernel Matrix: Added support for 5.15 and 6.8 for (ubuntu22.04)
Base Target and LTS KERNEL Version Matrix: Added support for Jammy and Noble.
Hardcoded Values Removed:
base_target_ubuntu22_04, base_target_ubuntu24_04, and lts_kernel_ubuntu24_04 are now dynamically handled instead of being hardcoded.
Skipped Unsupported Versions:
base_target = noble && dist = ubuntu22.04
base_target = jammy && dist = ubuntu24.04
base_target = noble && lts_kernel = 5.15
driver_branch = 535 && dist = ubuntu24.04
Removed downloading of kernel_version.txt from the Docker build-base.
Now, artifacts-based download is considered instead.
Reason: When building the base via make build-base-jammy, it now includes two LTS kernels (Ubuntu 22.04: 5.15 and 6.8). Running a parallel matrix will cause make build-base-jammy to overwrite( 5.15 and 6.8) kernel-version.txt, leading to incorrect values in matrix_values files during download with regctl in determine-e2e-test-matrix job.
Solution: Either modify the Makefile to introduce a new command (make build-base-${base_target}-${lts_kernel}) or directly download kernel_version.txt from artifacts.
Since kernel_version... files are already being uploaded as artifacts, we now rely on those values._
Added --paginate option in gh Get API for artifact listing to support more than 30 artifacts.