링크 생성하기 뷰 링크 생성 post 누나쿵 #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100Gyeon
approved these changes
Jan 21, 2022
SeojinSeojin
requested changes
Jan 21, 2022
| return NEOSOSEO_FORM_DATA.FORM; | ||
| }; | ||
|
|
||
| const postFormAnswer = async (body: NeososeoAnswerData) => { |
There was a problem hiding this comment.
이 부분 내 코드에 있던 부분 같은데 커밋이 된겨??
There was a problem hiding this comment.
지금 dev에 있는 코드랑 아예 다른 것 같은데 머지하고 다시 푸시해줄 수 있어?
| }, []); | ||
|
|
||
| useEffect(() => console.log('here'), [link]); |
| const q = await api.neososeoFormService.postCreateForm(Number(formID), () => | ||
| navigate(`/neoga/create/${formID}/created`), | ||
| ); | ||
| setLink(`http://localhost:3000/neososeoform/${q}`); |
There was a problem hiding this comment.
우리 도메인으로 바꾸어 주세요!!
링크를 state로 관리한건 아주 좋은 선택인듯!
대신 그럼 아래에서 클립보드 복사 눌렀을 때 링크가 빈 스트링("")일 경우 다시 시도하라고 말해줘야 할듯해!!
| console.log(e.response); | ||
| }); | ||
| if (response.status === 200 && response.message === '폼 생성 성공') { | ||
| console.log(response.data); |
|
울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~ |
Hyoin-Kim
approved these changes
Jan 21, 2022
|
울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~ |
|
울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛓ Related Issues
📋 작업 내용
📌 PR Point
누나쿵